Remove extra '/' when findShortestPath $from is a directory

[gmsantos]

Resolves #3024

Passing the third argument as true on findShortestPath method, a dummy file is added to $from.
If $from ends with / (e.g. C:/ , /foo/bar/ ), a second / is inserted resulting on a invalid path.

[alcohol]

Please rename the function as it does not relate to the context. To check if you're dealing with a directory you would use http://php.net/is_dir. You are simply interested in knowing if the string ends with a / or not. That doesn't have anything to do with it actually being a directory.

The problem here is that after the normalizePath() call (which strips trailing / characters), root paths remain / (on *nix) and <DRIVE>:/ (on windows). This then turns $from into //dummy_file on *nix and into c://dummy_file on windows. The function then correctly determines the path on *nix, but fails on windows.

On *nix the $commonPath ends up being / which then results in simply returning $to as shortest path. On Windows the $commonPath value is c: which does not equal / so it continues processing and ends up with the leading ../.

[stof]

why it is public ?

[Seldaek]

Yeah that should definitely be private or made to work with \ paths as well, because as is it depends on the path being normalized first.

[Seldaek]

Thanks