disable path if no composer available, fixes #4101 #4111
Conversation
gracefully remove the option and continue, after informing the user
| @@ -196,6 +196,11 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| $width--; | |||
| } | |||
|
|
|||
| if ($input->getOption('path') && null === $composer) { | |||
| $this->getIO()->writeError('No composer.json found in the current directory, disabling "path" option'); | |||
There was a problem hiding this comment.
Shouldn't this be on a debug verbosity?
There was a problem hiding this comment.
The message should state: composer.json was not found in the current directory. Disabling "path" option.. It has a more humane sound to it.
There was a problem hiding this comment.
I kept the message in line with other messages in the show command. As for verbosity, no verbosity flags are used in similar situations in the show command.
There was a problem hiding this comment.
Sure, ok. But you're adding to the "grunt work" (I'm quoting you) in case a log verbosity overhaul is needed in the future.
There was a problem hiding this comment.
True, but until any decisions are made on how/what regarding that, it doesn't make sense to "plan for the future" as long as the future remains unclear.
…ailable disable path if no composer available, fixes #4101
gracefully remove the option and continue, after informing the user