Output script command in verbose mode #4123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO it should be shown even in quiet mode. It is not too verbose to begin with and otherwise it would be meaningless for the use case described in #4120. |
alcohol
force-pushed
the
output-script-command-in-verbose-mode
branch
from
e85e562
to
9223f4a
Compare
|
what about the case of PHP scripts ? |
|
What exactly do you mean? Like.. ? |
Seldaek
added a commit
that referenced
this pull request
Jul 4, 2015
|
Thanks, I added the event name in verbose mode too, I think this might become a pain for people with plugins having lots of listeners though so we might need to downgrade it to -v/-vv instead of */-v but let's see how it goes. |
naderman
added a commit
to naderman/composer
that referenced
this pull request
Jul 6, 2015
…oviders-2 * github-composer/master: (64 commits) Fix tests Add event name in verbose mode, refs composer#4123 Use only one level of verbosity Rendering fix, refs composer#4172 Formatting tweaks, refs composer#4172 Minor tweaks, refs composer#4172 Revert "apply a regex solution instead of tokenizer" apply a regex solution instead of tokenizer updated spdx related files Mark VersionParser::formatVersion() as deprecated Update callers of VersionParser::formatVersion() Move VersionParser::formatVersion() to BasePackage::getFullPrettyVersion() Changing config.json to satis.json Fix: Import Symfony\Component\Finder\Finder CS fixes outside of table, no need to escape added some links and some restructuring better phrasing / structure + moved version testing link reworking basic usage, added versions article add installer information ... Conflicts: src/Composer/Repository/ComposerRepository.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #4120
Not sure if we should only show it in verbose mode, or show by default and hide in quiet mode. Feedback/thoughts?
/cc @Seldaek @theofidry