New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention need to require autoloader in hooks using functions #4187
Mention need to require autoloader in hooks using functions #4187
Conversation
…ire the autoloader file in order to use autoloaded files
|
This will fail if |
|
@alcohol As we discussed in #4184, I believe the existing disclaimer about the state of the autoloader being undetermined in pre-install and pre-update commands covers the possible non-existence of |
|
Well at least set a good example :-(. Also I think the current wording is a bit vague as to what kind of functions you are referring to. Remove the reiteration of the disclaimer (it's not necessary), and try to emphasise it's about functions that are normally only available via the |
|
What phrasing would you suggest is more clear than 'functions defined outside of a class'? I've always found interpolation to be cleaner, and since there's no performance difference between interpolation and concatenation, we'll have to agree to disagree on the aesthetics. |
|
We can disagree on aesthetics, but we can agree on convention. So if you don't mind. |
|
As for phrasing, maybe it's better to turn it around and simply make it more clear that "must be autoloadable via Composer's autoload functionality" does not mean that the autoloader is actually loaded, but merely that the same mechanism is used and that this only applies to the |
|
@alcohol Were there any other changes you wanted to see made? |
|
Well,
could probably better be phrased as
|
Add a line and example to the documentation covering the need to require the autoloader file in order to use autoloaded files.
Addresses #4184