Fix #4183 - exclude pattern containing delimiter used throws error

[alcohol]

Added test to reproduce #4183

Not sure on what the best way to fix it would be..

• Escape any delimiter characters used in the pattern?
• Use a different delimiter?

/cc @Seldaek @stof

[staabm]

Using a different delimiter does not sound like a good idea. someone will collide with it again ;-).

could we do a preg_quote instead?

[alcohol]

I believe preg_quote would escape too much (I did consider it for a moment). I think escaping the delimiter is the most elegant solution. However, I'm not sure if my fix catches all scenarios.

[Seldaek]

That's why I use {} as delimiters always.. because they are already special chars that you need to escape either way, and don't cause fuckups like this. Just convert the # delimiter to {/} and it should fix this issue as far as I can tell.

[staabm]

👍