Implementation of array for repositories.tags-path and repositories.branches-path
#5142
Conversation
…tis.json configurations
…t tags-path and branches-path
| $tagsPath = 'tags'; | ||
| if (isset($packageConfig['branches-path'])) { | ||
| $branchesPath = (is_array($packageConfig['branches-path'])) ? implode('|', $packageConfig['branches-path']) : $packageConfig['branches-path']; | ||
| $branchesPath = preg_quote($branchesPath, '#'); |
There was a problem hiding this comment.
using preg_quote here will not allow supporting multiple paths, as it will escape the | used when imploding above. you need to quote each path separately instead.
There was a problem hiding this comment.
@stof Very good point, I will change this.
|
TBH, that's a lot of changes to review for adding more obscure features to the (somewhat legacy) SVN driver for an edge case that most likely only benefits you. I can't stay this perspective excites me a whole lot :/ Have you considered maybe switching to a more standard directory structure? This would be time better spent I feel. |
|
@Seldaek on the other hand, since it only affects the SVN driver and repos, there isn't much harm in accepting these changes. I can see merit in these changes. As a team (@composer), we can simply state that SVN support is provided by the community/contributors, and as such we do not directly support it ourselves. Any issues arising from this would either result in a new patch from contributors, or we simply revert the merge if no solution is provided in a timely fashion. |
|
Yeah, I don't really mind as it's svn-only, but there is some feedback above that still wasn't addressed, which is the main reason this wasn't merged yet. |
|
I also wonder if it's really that important if people manage to get by without such a patch for a few months.. |
I've implemented
arrayawareness to therepositories.tags-pathandrepositories.branches-pathconfiguration clauses, because in SVN you are able to create more complex tags and branches directories, where you may have multiple sub-directories (as my employer does).This relates to a issue I submitted to the "composer/satis": composer/satis#312
I'll also be submitting a JSON schema update for the satis.json definition.