New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump symfony/process to 2.3 - and raise minimum php to 5.3.3 #5831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably update the lock file too (composer update --lock)?
Also should be applied to the 1.2 branch and then we will merge it into master from there, since technically this is a bug I believe. Other than that, LGTM.
|
Unable to rebase it? If it is too much work for you, we can probably do it. We just appreciate it if you could do it instead, cause it saves us the hassle. |
|
@alcohol no it's fine - will do it after work :) |
|
Ok. Was just checking, cause I saw you changed the target but then changed it back :-) |
|
I thought it was as simple as that, but I have to rebase locally and fix some conflicts, will probably be quicker to just do it again 😄 |
|
Yeah, probably will be. You could use the patch. Simply take the 2 commits and apply their patch on a new branch: git format-patch -2 HEAD --stdout > /tmp/composer.patch
git checkout -b tmp-branch 1.2
git apply - < /tmp/composer.patch
git commit -p # interactively add and commit changes
git push -f origin update-symfony-process |
|
For 2 lines redoing the change on the proper branch is always faster 😆 |
a3f36b9
to
b3280eb
Compare
|
@alcohol should be done now - let me know if there's anything else |
|
Thanks |
|
Thanks but re 5.3.3 bump I don't think this matters much as of our users don't install composer via composer so this has little impact. But anyway this shouldn't reflect the minimum version required by our deps but by our own code. Composer takes care of enforcing the minimum version required by the deps. |
Refs #5828
I've only updated
composer.json- let me know if there is something else that should be added.