New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BC of generated static map #6973

Merged
merged 1 commit into from Jan 4, 2018

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Contributor

nicolas-grekas commented Jan 4, 2018

This needs an emergency release, as it breaks using legacy class-loader, like the one bundled into phpunit.
ping @Seldaek

@Seldaek

This comment has been minimized.

Show comment
Hide comment
@Seldaek

Seldaek Jan 4, 2018

Member

Any details on what/how it breaks? Just trying to understand here..

Member

Seldaek commented Jan 4, 2018

Any details on what/how it breaks? Just trying to understand here..

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Jan 4, 2018

Contributor

How: see https://travis-ci.org/symfony/symfony/jobs/324996450
Why: missing prefixLengthsPsr4 map in newly dumped static map breaks the ClassLoader provided by phpunit (old one)

Contributor

nicolas-grekas commented Jan 4, 2018

How: see https://travis-ci.org/symfony/symfony/jobs/324996450
Why: missing prefixLengthsPsr4 map in newly dumped static map breaks the ClassLoader provided by phpunit (old one)

@Seldaek

This comment has been minimized.

Show comment
Hide comment
@Seldaek

Seldaek Jan 4, 2018

Member

I see.. but I am not sure if the fix will really fix it then. What if you dump a completely new loader into that dir (so it won't add the prefixLengthsPsr4 at all) and then phpunit will break?

Member

Seldaek commented Jan 4, 2018

I see.. but I am not sure if the fix will really fix it then. What if you dump a completely new loader into that dir (so it won't add the prefixLengthsPsr4 at all) and then phpunit will break?

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Jan 4, 2018

Contributor

What about reverting 3be9591 then?
With static arrays in shared memory, the gain is non existent anyway.

Contributor

nicolas-grekas commented Jan 4, 2018

What about reverting 3be9591 then?
With static arrays in shared memory, the gain is non existent anyway.

@Seldaek

This comment has been minimized.

Show comment
Hide comment
@Seldaek

Seldaek Jan 4, 2018

Member

Yeah I think that might be the only way forward. It sucks that we basically can't make any change to this code though with the static array. I'll work on a partial revert as we can still keep some of the changes.

Member

Seldaek commented Jan 4, 2018

Yeah I think that might be the only way forward. It sucks that we basically can't make any change to this code though with the static array. I'll work on a partial revert as we can still keep some of the changes.

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Jan 4, 2018

Contributor

(revert pushed)

Contributor

nicolas-grekas commented Jan 4, 2018

(revert pushed)

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Jan 4, 2018

Contributor

I'll work on a partial revert as we can still keep some of the changes

already done here :)

Contributor

nicolas-grekas commented Jan 4, 2018

I'll work on a partial revert as we can still keep some of the changes

already done here :)

@Seldaek

This comment has been minimized.

Show comment
Hide comment
@Seldaek

Seldaek Jan 4, 2018

Member

Yup I see, sorry have 5 things going on atm :/ Looks good to me except I don't know if it'll break people that upgraded to 1.6.0 and already dumped a new autoloader.. Maybe we need reverse-BC code?

Member

Seldaek commented Jan 4, 2018

Yup I see, sorry have 5 things going on atm :/ Looks good to me except I don't know if it'll break people that upgraded to 1.6.0 and already dumped a new autoloader.. Maybe we need reverse-BC code?

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Jan 4, 2018

Contributor

Here we are.

Contributor

nicolas-grekas commented Jan 4, 2018

Here we are.

@Seldaek

This comment has been minimized.

Show comment
Hide comment
@Seldaek

Seldaek Jan 4, 2018

Member

Thanks.. Let's hope no further adverse effect.

Member

Seldaek commented Jan 4, 2018

Thanks.. Let's hope no further adverse effect.

@Seldaek Seldaek merged commit ebc3c7d into composer:1.6 Jan 4, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fix-autoloader branch Jan 4, 2018

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Jan 4, 2018

Contributor

I beg for a new tag please :)

Contributor

nicolas-grekas commented Jan 4, 2018

I beg for a new tag please :)

@Seldaek

This comment has been minimized.

Show comment
Hide comment
@Seldaek

Seldaek Jan 4, 2018

Member

Yes yes sorry everything is on fire right now, on it ASAP

Member

Seldaek commented Jan 4, 2018

Yes yes sorry everything is on fire right now, on it ASAP

@Seldaek

This comment has been minimized.

Show comment
Hide comment
@Seldaek

Seldaek Jan 4, 2018

Member

Also why are you the only one affected here? Anything special symfony is doing? I just wonder why travis builds haven't caught fire everywhere.

Member

Seldaek commented Jan 4, 2018

Also why are you the only one affected here? Anything special symfony is doing? I just wonder why travis builds haven't caught fire everywhere.

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Jan 4, 2018

Contributor

I think it's because of a cached ClassLoader that were compiled when symfony/phpunit-bridge compiled its variant of phpunit. There must be some unusual autoloader loading logic there.

Contributor

nicolas-grekas commented Jan 4, 2018

I think it's because of a cached ClassLoader that were compiled when symfony/phpunit-bridge compiled its variant of phpunit. There must be some unusual autoloader loading logic there.

@Seldaek

This comment has been minimized.

Show comment
Hide comment
@Seldaek

Seldaek Jan 4, 2018

Member

Ok 1.6.1 is out

Member

Seldaek commented Jan 4, 2018

Ok 1.6.1 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment