Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalChanges for ArchiveFiles #7095

Closed
wants to merge 1 commit into from
Closed

LocalChanges for ArchiveFiles #7095

wants to merge 1 commit into from

Conversation

hectorprats
Copy link
Contributor

@hectorprats hectorprats commented Feb 8, 2018

Added LocalChanges detector for ArchiveFiles
Passed php-cs-fixer

@hectorprats
Copy link
Contributor Author

can anyone to check it?

@staabm
Copy link
Contributor

staabm commented Mar 13, 2018

this PR would be easier to review and handle if it would not contain CS changes.

Jordi will take care of CS from time to time, no need to run the fixer across the whole codebase with a PR.

@hectorprats
Copy link
Contributor Author

hectorprats commented Mar 13, 2018

You are right, I will prepare a version without CS fixer, but I only did the good practices that you put in the contributor doc.

I think I am the only one that done it.

@staabm
Copy link
Contributor

staabm commented Mar 13, 2018

my comment was just a tip on how you can increase likelyhood of your change beeing considered/reviewed. you did a great job, thx for contributing.

but I only did the good practices that you put in the contributor doc.

in which file exactly did you find it? maybe we need to fix them

@hectorprats
Copy link
Contributor Author

@hectorprats
Copy link
Contributor Author

hectorprats commented Mar 13, 2018

my comment was just a tip on how you can increase likelyhood of your change beeing considered/reviewed.

Maybe I'm not repond well, but only is cause of my poor english. Sorry, and thanks :-)

@staabm
Copy link
Contributor

staabm commented Mar 13, 2018

No worries. Lets see what the maintainers say...

@hectorprats
Copy link
Contributor Author

I create new PR without CS fixes in #7191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants