Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a case insenstive method to check that SHA384 is a supported openssl algorithm #7649

Merged

Conversation

@aragon999
Copy link
Contributor

@aragon999 aragon999 commented Sep 17, 2018

This pull request ports the fix from the installer script, see here composer/getcomposer.org#128, to the composer self-update command, where the same bug is present.

@aragon999 aragon999 force-pushed the aragon999:bugfix/fix-detection-of-supported-ssl-algos branch from b91d608 to 7ad6a56 Sep 18, 2018
@alcohol alcohol requested a review from Seldaek Sep 19, 2018
@alcohol
Copy link
Member

@alcohol alcohol commented Sep 19, 2018

@Seldaek
Copy link
Member

@Seldaek Seldaek commented Sep 24, 2018

@aragon999 can you please rebase this on the 1.7 branch?

@Seldaek Seldaek changed the base branch from master to 1.7 Sep 24, 2018
@Seldaek Seldaek added this to the 1.7 milestone Sep 24, 2018
@Seldaek Seldaek added the Bug label Sep 24, 2018
@aragon999 aragon999 force-pushed the aragon999:bugfix/fix-detection-of-supported-ssl-algos branch from 7ad6a56 to 505542e Sep 24, 2018
@aragon999
Copy link
Contributor Author

@aragon999 aragon999 commented Sep 24, 2018

@Seldaek done :-)

@alcohol
Copy link
Member

@alcohol alcohol commented Sep 24, 2018

Are you sure? It does not look rebased properly. Is your 1.7 branch up to date?

@aragon999 aragon999 force-pushed the aragon999:bugfix/fix-detection-of-supported-ssl-algos branch from 505542e to 4d86414 Sep 24, 2018
@aragon999
Copy link
Contributor Author

@aragon999 aragon999 commented Sep 24, 2018

@alcohol sorry that was my mistake, should be fixed now

@Seldaek
Copy link
Member

@Seldaek Seldaek commented Sep 24, 2018

Thanks

@Seldaek Seldaek merged commit 7e2e231 into composer:1.7 Sep 24, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aragon999 aragon999 deleted the aragon999:bugfix/fix-detection-of-supported-ssl-algos branch Sep 24, 2018
hswong3i added a commit to pantarei/ansible-playbook-ubuntu-desktop that referenced this pull request Oct 23, 2018
hswong3i added a commit to alvistack/ansible-role-php that referenced this pull request Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants