New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use junctions if they can be safely removed #7971

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
3 participants
@johnstevenson
Copy link
Member

johnstevenson commented Feb 11, 2019

I'm probably jumping the gun a bit here since the PHP bug fixes haven't been released yet (they are merged now), but otherwise I'll have forgotten all about this in a month.

@Seldaek

This comment has been minimized.

Copy link
Member

Seldaek commented Feb 12, 2019

Makes sense, thanks. It should still use Junctions for now on older PHPs as long as you're on windows 7+ if I understand correctly, so strictly speaking no change except upcoming PHP versions won't check the windows version anymore?

@Seldaek Seldaek added this to the 1.8 milestone Feb 12, 2019

@johnstevenson

This comment has been minimized.

Copy link
Member Author

johnstevenson commented Feb 12, 2019

The only change now is that we won't allow junctions if they can only be removed via php (ie no proc_open).

@Seldaek Seldaek merged commit 4d26198 into composer:1.8 Feb 12, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@johnstevenson johnstevenson deleted the johnstevenson:safe-junctions branch Feb 12, 2019

@curry684

This comment has been minimized.

Copy link
Contributor

curry684 commented Feb 12, 2019

Awesome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment