Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using composer with symfony/process:^4 #8358

Closed

Conversation

@glaubinix
Copy link
Contributor

commented Oct 4, 2019

Hi,

this PR removes a deprecation warning/exception when using composer in a project with never symfony/process versions.

Starting with symfony/process:3.4 running a process in a directory which doesn't exist throws a deprecation warning and starting with symfony/process:4 this throws an exception see: https://github.com/symfony/process/blob/a305eb1f68e6a16009ddc26f2f97cd96e30cfae5/Process.php#L329-L331

Compared to the current implementation this will now always create an empty directory whenever we run a command in that directory e.g. when we run git clone for a vcs repository. To keep the current behaviour consistent shall I delete the directory after the command is run if it is empty? This happens for instance when git clone fails.

@Seldaek

This comment has been minimized.

Copy link
Member

commented Oct 6, 2019

Is the current behavior not to run the command in getcwd() in case the provided directory doesn't exist? Wondering if we shouldn't do that too then.. Or rather fix the places where the invalid calls are made. Magically creating the directory sounds like it's gonna bite us in the ass at some point in the future.

@Seldaek Seldaek added this to the 1.9 milestone Oct 6, 2019
@Seldaek Seldaek added the Bug label Oct 6, 2019
@glaubinix

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2019

Sounds good. After further investigating this I believe that the deprecations warnings we see are because of an error on how we integrate composer usage i.e. using the vcs driver for operations even though initialize of the driver failed.

I will reopen this with more information after we deployed some changes if and when this still happens and adjust this only where necessary.

@glaubinix glaubinix closed this Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.