Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix using composer with symfony/process:^4 #8358
this PR removes a deprecation warning/exception when using composer in a project with never
Compared to the current implementation this will now always create an empty directory whenever we run a command in that directory e.g. when we run git clone for a vcs repository. To keep the current behaviour consistent shall I delete the directory after the command is run if it is empty? This happens for instance when git clone fails.
Is the current behavior not to run the command in
Sounds good. After further investigating this I believe that the deprecations warnings we see are because of an error on how we integrate composer usage i.e. using the vcs driver for operations even though initialize of the driver failed.
I will reopen this with more information after we deployed some changes if and when this still happens and adjust this only where necessary.