Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command::execute() should always return an integer #8360

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@derrabus
Copy link
Contributor

commented Oct 7, 2019

In Symfony 4.4, a deprecation error is triggered if Command::execute() does not return an integer, see symfony/symfony#33747. This PR adds the necessary return statements.

@Seldaek Seldaek merged commit 82d0b12 into composer:1.9 Oct 8, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Seldaek

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

Thanks

@derrabus derrabus deleted the derrabus:bugfix/execute-returns-0 branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.