Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactor, fix failing test #hacktoberfest #8361

Closed
wants to merge 2 commits into from

Conversation

@proggga
Copy link

commented Oct 7, 2019

No description provided.

proggga added 2 commits Oct 7, 2019
@proggga proggga force-pushed the proggga:proggga/small_fix branch from 6fbe1e7 to 73bcac0 Oct 7, 2019
@proggga proggga changed the title Small refactor #hacktoberfest Small refactor, fix failing test #hacktoberfest Oct 7, 2019
@alcohol
alcohol approved these changes Oct 8, 2019
@Seldaek

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

The fix for clearstatcache makes sense I think /cc @curry684

The other changes removing $dummy vars I don't see the point. Extracting all array keys to do the foreach is kind of a waste, so why fix something that doesn't need fixing?

@proggga

This comment has been minimized.

Copy link
Author

commented Oct 8, 2019

Clean code: remove useless variables, and remove strangw var delete

@proggga

This comment has been minimized.

Copy link
Author

commented Oct 8, 2019

Created new mr only with cache fix
#8366

@proggga proggga closed this Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.