Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add messages to junction tests to see failures #8367

Open
wants to merge 1 commit into
base: 1.9
from

Conversation

@johnstevenson
Copy link
Member

commented Oct 8, 2019

I'm trying to track down the seemingly random failures on Appveyor. This first step is to see if there is a single failing condition (which I doubt).

@johnstevenson

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2019

Ha ha, perfect!

Despite the appveyor test on my fork succeeding (https://ci.appveyor.com/project/johnstevenson/composer/builds/27966702), the one for this PR failed (https://ci.appveyor.com/project/Seldaek/composer/builds/27966930)

More confusingly, it failed trying to remove the junction stating that:

... is not a junction and thus cannot be removed as one

having successfully tested that it is a junction 3 times.

@Seldaek

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

See also #8366

@johnstevenson

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2019

Yeah, I saw that after I'd opened the PR. I don't know if moving the clearstatcache call before the not-a-directory-or-is-a-link check would make much difference.

Would this PR be better on master or 1.9?

@Seldaek

This comment has been minimized.

Copy link
Member

commented Oct 9, 2019

@curry684

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

The test would fail if the underlying filesystem is not NTFS. Unheard in the real world but possible...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.