Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 5 #8432

Merged
merged 2 commits into from Nov 17, 2019
Merged

Allow Symfony 5 #8432

merged 2 commits into from Nov 17, 2019

Conversation

@kylekatarnls
Copy link
Contributor

kylekatarnls commented Nov 16, 2019

No description provided.

@kylekatarnls

This comment has been minimized.

Copy link
Contributor Author

kylekatarnls commented Nov 16, 2019

The continuous-integration/appveyor/pr — AppVeyor build failed error seems not related to this change as it downloads symfony 2.* version.

@Seldaek Seldaek merged commit 6ffd3eb into composer:master Nov 17, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Seldaek

This comment has been minimized.

Copy link
Member

Seldaek commented Nov 17, 2019

Thanks

@kylekatarnls kylekatarnls deleted the kylekatarnls:patch-2 branch Nov 17, 2019
@peter-gribanov peter-gribanov mentioned this pull request Jan 16, 2020
@peter-gribanov

This comment has been minimized.

Copy link

peter-gribanov commented Jan 16, 2020

When can i expect a release with this feature?

@Seldaek

This comment has been minimized.

Copy link
Member

Seldaek commented Jan 16, 2020

When it's done. But most likely soon.

@TomasVotruba

This comment has been minimized.

Copy link
Contributor

TomasVotruba commented Jan 23, 2020

This blocks my Symfony 5.0 build :/

@brianfreytag

This comment has been minimized.

Copy link

brianfreytag commented Feb 12, 2020

@Seldaek Do you have an update on this? I'm still trying to get my 5.0 upgrade going, but this is holding us up.

@kylekatarnls

This comment has been minimized.

Copy link
Contributor Author

kylekatarnls commented Feb 12, 2020

🙏 Please a minor version with this PR.

@Seldaek

This comment has been minimized.

Copy link
Member

Seldaek commented Feb 14, 2020

1.10.0-RC is out now.. Please note that you could also have required "composer/composer": "^1.10@dev" to use pre-release code without pestering us about a release..

Anyway now you can use "composer/composer": "^1.10@RC" which is rather future proof, or if you are using composer as a CLI util composer self-update --preview

@kylekatarnls

This comment has been minimized.

Copy link
Contributor Author

kylekatarnls commented Feb 14, 2020

Thanks @Seldaek but sorry it's not the same, when you deliver a library using composer/composer and wanting to be compatible with symfony 5, requiring "^1.10@dev" won't make your library compatible with Symfony 5 for users that stay on "minimum-statbility": "stable".

You can only choose @dev if you're on the end of the chain. And it requires to undertake the instability risk.

So I would say, providing dev/alpha/beta/RC channels is nice and I thank your for it. But it can't exactly substitute stable releases. Until a stable release, composer is still not compatible with Symfony 5.

Of course releasing an RC before the stable and waiting for feedback on it is the right move.

So thanks!

@Seldaek

This comment has been minimized.

Copy link
Member

Seldaek commented Feb 14, 2020

Yup fair enough for libraries this is trickier, although it would let you fix your build at least.. and let users who really want also require composer/composer @dev or @RC to allow it to install. But anyway I hope there are not too many issues with the RC and we can move on to a final release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.