Remove YiiInstaller #68

Closed
schmunk42 opened this Issue Apr 10, 2013 · 5 comments

Comments

Projects
None yet
2 participants
@schmunk42
Contributor

schmunk42 commented Apr 10, 2013

I am sorry that I have to create this issue, but please remove the YiiInstaller from composer/installers.

As discussed on composer-dev and Yii issues there are no specifications for Yii 1.x applications how they have to be structured and the current installer might break existing composer-based Yii applications.

@schmunk42

This comment has been minimized.

Show comment Hide comment
@schmunk42

schmunk42 Apr 10, 2013

Contributor

PS: But for sure Yii 1.x stays a natively supported framework for composer.

PS2: you could use "vendor-dir": "protected/extensions" to achieve a similar functionality.

Contributor

schmunk42 commented Apr 10, 2013

PS: But for sure Yii 1.x stays a natively supported framework for composer.

PS2: you could use "vendor-dir": "protected/extensions" to achieve a similar functionality.

@shama

This comment has been minimized.

Show comment Hide comment
@shama

shama Apr 11, 2013

Contributor

👍 Will remove it shortly. Thanks for handling this!

Contributor

shama commented Apr 11, 2013

👍 Will remove it shortly. Thanks for handling this!

@schmunk42

This comment has been minimized.

Show comment Hide comment
@schmunk42

schmunk42 Apr 11, 2013

Contributor

Before you remove it, there is a use-case for a YiiInstaller, but I am not sure if it could be implemented.

When installing a yii-theme, the theme should be installed (or copied) into your theme folders. You can only customize a general theme directory in Yii for all themes, not for every theme separately.

And I used the plural form, because a theme has asset-files in a public accessible section and view and skin files in something like app/ or protected/.

So the package would have to be split up into two parts, when installing - which makes no sense, because it's a repo. I am using this command at the moment to accomplish the task and my theme belongs to my project.

How to do this with composer/installers?

Contributor

schmunk42 commented Apr 11, 2013

Before you remove it, there is a use-case for a YiiInstaller, but I am not sure if it could be implemented.

When installing a yii-theme, the theme should be installed (or copied) into your theme folders. You can only customize a general theme directory in Yii for all themes, not for every theme separately.

And I used the plural form, because a theme has asset-files in a public accessible section and view and skin files in something like app/ or protected/.

So the package would have to be split up into two parts, when installing - which makes no sense, because it's a repo. I am using this command at the moment to accomplish the task and my theme belongs to my project.

How to do this with composer/installers?

@schmunk42 schmunk42 referenced this issue in yiisoft/yii Apr 11, 2013

Closed

Official Yii 1.x composer installer #2313

@shama

This comment has been minimized.

Show comment Hide comment
@shama

shama Apr 17, 2013

Contributor

@schmunk42 That seems like a good use case for a post-install-cmd: http://getcomposer.org/doc/articles/scripts.md

Contributor

shama commented Apr 17, 2013

@schmunk42 That seems like a good use case for a post-install-cmd: http://getcomposer.org/doc/articles/scripts.md

@schmunk42

This comment has been minimized.

Show comment Hide comment
@schmunk42

schmunk42 Apr 18, 2013

Contributor

@shama Thanks :) I am using those events extensively. Just running some yiic commands when a package gets installed.

That would be a nice solution for a Yii installer, but there are problems relying on a package for scripts, see composer/composer#1799 - Therefore I had to bundle my ComposerCallback class with my project template.

Any ideas?

PS: Should I send a pull request for this ;)?

Contributor

schmunk42 commented Apr 18, 2013

@shama Thanks :) I am using those events extensively. Just running some yiic commands when a package gets installed.

That would be a nice solution for a Yii installer, but there are problems relying on a package for scripts, see composer/composer#1799 - Therefore I had to bundle my ComposerCallback class with my project template.

Any ideas?

PS: Should I send a pull request for this ;)?

shama added a commit that referenced this issue May 7, 2013

@schmunk42 schmunk42 closed this May 8, 2013

@shama shama referenced this issue in composer/composer Jun 3, 2013

Closed

Custom install path for user-defined packages #1948

@schmunk42 schmunk42 referenced this issue in yiisoft/yii2 Oct 20, 2013

Closed

Yii2 extension skeleton #389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment