Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Remove YiiInstaller #68

Closed
schmunk42 opened this Issue · 5 comments

2 participants

@schmunk42

I am sorry that I have to create this issue, but please remove the YiiInstaller from composer/installers.

As discussed on composer-dev and Yii issues there are no specifications for Yii 1.x applications how they have to be structured and the current installer might break existing composer-based Yii applications.

@schmunk42

PS: But for sure Yii 1.x stays a natively supported framework for composer.

PS2: you could use "vendor-dir": "protected/extensions" to achieve a similar functionality.

@shama
Owner

:thumbsup: Will remove it shortly. Thanks for handling this!

@schmunk42

Before you remove it, there is a use-case for a YiiInstaller, but I am not sure if it could be implemented.

When installing a yii-theme, the theme should be installed (or copied) into your theme folders. You can only customize a general theme directory in Yii for all themes, not for every theme separately.

And I used the plural form, because a theme has asset-files in a public accessible section and view and skin files in something like app/ or protected/.

So the package would have to be split up into two parts, when installing - which makes no sense, because it's a repo. I am using this command at the moment to accomplish the task and my theme belongs to my project.

How to do this with composer/installers?

@schmunk42 schmunk42 referenced this issue in yiisoft/yii
Closed

Official Yii 1.x composer installer #2313

@shama
Owner

@schmunk42 That seems like a good use case for a post-install-cmd: http://getcomposer.org/doc/articles/scripts.md

@schmunk42

@shama Thanks :) I am using those events extensively. Just running some yiic commands when a package gets installed.

That would be a nice solution for a Yii installer, but there are problems relying on a package for scripts, see composer/composer#1799 - Therefore I had to bundle my ComposerCallback class with my project template.

Any ideas?

PS: Should I send a pull request for this ;)?

@schmunk42 schmunk42 referenced this issue from a commit in schmunk42/installers
@schmunk42 schmunk42 removed Yii installer, issue #68 5db6e2d
@schmunk42 schmunk42 closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.