[BC hotfix] Revert typo3 installer deletion #300
Conversation
|
Back and forth might cause even more confusion. But if this is reverted again, then the deprecation message should be visible during build time, not only in the readme |
|
It might cause confusion. But the deletion is a major BC break and causes real problems. Never do this in bugfix releases. Feel free to add a deprecation to the installer after it got reverted ;) |
It might be natural for you to value your problems higher than other peoples problems. Anyway, please do what you consider best, I will not waste more time here. |
|
I care about semantic versioning and backwards compatibility. If we profit from it, yayyy. Everyone profits from semver and caring about BC.
|
|
No need to comment on BC, semver or compatiblility. Everybody knows how it works… One last comment however on the reasoning why we from the TYPO3 community consider it an improvement if TYPO3 extensions are not handled any more by composer/installers We like to be a nice citizen in the PHP community and be operational in combination with other PHP projects. This means we would like TYPO3 projects to be installable with other projects that require composer/installers. This is not possible with the installer code for TYPO3 extensions which is/was present here, because both installers did conflicting operations in certain situation, which left the TYPO3 installation in an unsusable state. We mitigated this on our side, by adding a conflict declaration to our installer. But this violates our initial goal of being a good citizen. We are not aware of any other solution to fully fix this, besides removing the installer code here. Our final goal is, that TYPO3 will not require any special installer code, but it will take a while until we get there. Hope this clears things up a bit. I respect any decision taken here. We can also live with a broken installer here and a conflict declaration on our side, although we would not choose this option. |
…stallers See composer/installers#300 for a discussion on that topic
…stallers See composer/installers#300 for a discussion on that topic
|
|
||
| /** | ||
| * Extension installer for TYPO3 CMS | ||
| * |
There was a problem hiding this comment.
Add @deprecated tag with link to new installer, please.
|
@helhum remove installers this is a major change. It is better to leave the old installer, but make notice of his unfitness. For example, you can make PR, that would show notice during the installation of the package. Give people time to switch to the new installer ;) |
QuingKhaos
force-pushed
the
hotfix/revert-typo3-installer-deletion
branch
from
ac7e71b
to
24629e9
Compare
|
@niksamokhvalov Added the deprecated annotation to the installer class. |
|
v1.0.25 |
What's in this PR?
Reverting #281 which removed the TYPO3 CMS installer and added a deprecation notice to use the one from @helhum
Why?
Because the deletion of a installer is a majow BC break. It doesn't matter if there is an official one or not, you broke many projects now. Ours definitively and maybe other ones too. Feels like #npmGate 😈
And it is no problem to leave the installer here, as the now official typo3 composer installer has a conflict section against
composer/installers, thus no unforeseen side effects.Deprecations
Deprecated the TYPO3 installer in the README