Notification api #132

merged 4 commits into from Apr 13, 2012


None yet
3 participants

Seldaek commented Apr 13, 2012

No description provided.

naderman added a commit that referenced this pull request Apr 13, 2012

@naderman naderman merged commit 2b68759 into composer:master Apr 13, 2012

@@ -55,10 +61,11 @@ class Dumper
* @param string $webDir web root
* @param string $cacheDir cache dir
- public function __construct(RegistryInterface $doctrine, Filesystem $filesystem, $webDir, $cacheDir)
+ public function __construct(RegistryInterface $doctrine, Filesystem $filesystem, RouterInterface $router, $webDir, $cacheDir)

stof Apr 13, 2012


you should typehint the UrlGeneratorInterface as it is the only part of RouterInterface you really need :)

foreach ($packages as $package) {
$versions = array();
foreach ($package->getVersions() as $version) {
$versions[$version->getVersion()] = $version->toArray();
- $data[$package->getName()] = array('versions' => $versions);
+ $data['packages'][$package->getName()] = array($versions);

stof Apr 13, 2012


This changes the format of the packages.json, isn't it ?


Seldaek Apr 13, 2012


Well that file is now generated by the dumper, this controller is just there in case people do their own setup and don't call the packagist:dump command. Anyway the controller was outdated, so yes it changes it, but it just brings it in line with the dumper command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment