Fix webhook source identification #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub and GitLab both send `$payload['repository']['url']`, but only GitLab's payload contains `$payload['project']`. This ensures that the proper URLs are used from webhook payloads and fixes testing integrations with nonstandard URLs (for example, when developing integrations in a local instance of gitlab-development-kit).
|
@Seldaek Hey, I noticed you're the last person to modify this file. Can you give it a review? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub and GitLab both send
$payload['repository']['url'], but only GitLab's payload contains$payload['project'].This ensures that the proper URLs are used from webhook payloads when GitLab is configured with nonstandard URLs (for example, when developing integrations in a local instance of gitlab-development-kit).