add an absolute directory to dump package where you want #101

Merged
merged 1 commit into from Nov 30, 2013

Conversation

Projects
None yet
3 participants
@omansour

I found usefull not to dump packages inside the projet. Download is still allowed by adding a simple alias in my virtual host.

@@ -260,7 +260,11 @@ private function selectPackages(Composer $composer, OutputInterface $output, $ve
*/
private function dumpDownloads(array $config, array &$packages, OutputInterface $output, $outputDir)
{
- $directory = sprintf('%s/%s', $outputDir, $config['archive']['directory']);
+ if (isset($config['archive']['absolute-directory'])) {
+ $directory = sprintf('%s', $config['archive']['absolute-directory']);

This comment has been minimized.

@max-voloshin

max-voloshin Nov 30, 2013

Why do you use sprintf here instead of "as is" assignment?

@max-voloshin

max-voloshin Nov 30, 2013

Why do you use sprintf here instead of "as is" assignment?

Seldaek added a commit that referenced this pull request Nov 30, 2013

Merge pull request #101 from omansour/feature/absolute-directory
add an absolute directory to dump package where you want

@Seldaek Seldaek merged commit dfa3b84 into composer:master Nov 30, 2013

@Seldaek

This comment has been minimized.

Show comment
Hide comment
@Seldaek

Seldaek Nov 30, 2013

Member

Thanks, I'll remove the redundant sprintf() after merge

Member

Seldaek commented Nov 30, 2013

Thanks, I'll remove the redundant sprintf() after merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment