Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an absolute directory to dump package where you want #101

Merged
merged 1 commit into from Nov 30, 2013

Conversation

@omansour
Copy link
Contributor

@omansour omansour commented Nov 30, 2013

I found usefull not to dump packages inside the projet. Download is still allowed by adding a simple alias in my virtual host.

@@ -260,7 +260,11 @@ private function selectPackages(Composer $composer, OutputInterface $output, $ve
*/
private function dumpDownloads(array $config, array &$packages, OutputInterface $output, $outputDir)
{
$directory = sprintf('%s/%s', $outputDir, $config['archive']['directory']);
if (isset($config['archive']['absolute-directory'])) {
$directory = sprintf('%s', $config['archive']['absolute-directory']);

Why do you use sprintf here instead of "as is" assignment?

Seldaek added a commit that referenced this issue Nov 30, 2013
add an absolute directory to dump package where you want
@Seldaek Seldaek merged commit dfa3b84 into composer:master Nov 30, 2013
@Seldaek
Copy link
Member

@Seldaek Seldaek commented Nov 30, 2013

Thanks, I'll remove the redundant sprintf() after merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants