Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags-path and branches-path JSON schema update #320

Closed

Conversation

xylesoft
Copy link

@xylesoft xylesoft commented Apr 1, 2016

Implemented JSON schema update to validate the tags-path and branches-path configuration clauses, also enabled the possibility of using arrays for both path configurations.

This Pull Request relates to: #312 and composer/composer#5142

"type" : {
"type": "string",
"description": "Version control system type",
"enum": ["vcs","svn","git","hg"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's wrong. There are more type of repositories

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing ones: composer and package at least.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

artifact also

@stof
Copy link
Contributor

stof commented Apr 1, 2016

repositories should not have a strict validation in the Satis schema if it does not have it in the composer schema (as this config is about configuring composer itself)

@stof
Copy link
Contributor

stof commented Apr 1, 2016

The current PR will break the usage of Satis for many cases, as it misses lots of config

@xylesoft
Copy link
Author

xylesoft commented Apr 2, 2016

Thank you for the feedback @stof, could you please give more some details of the missing areas regarding the config?

Regarding the repositories, which repositories are missing (besides composer and package)? I'm in the understanding that the schema should be an outline to the implementations permissible repositories.

@alcohol
Copy link
Member

alcohol commented Apr 3, 2016

https://getcomposer.org/doc/05-repositories.md#types

Not sure how completely up to date the documentation is, but it should contain everything.

@alcohol
Copy link
Member

alcohol commented May 30, 2016

Not sure what to do with this since your PR is also still open @ Composer.

/cc @Seldaek can you provide some feedback? See also referenced issue composer/composer#5142

@alcohol alcohol closed this Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants