New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tags-path and branches-path JSON schema update
#320
tags-path and branches-path JSON schema update
#320
Conversation
| "type" : { | ||
| "type": "string", | ||
| "description": "Version control system type", | ||
| "enum": ["vcs","svn","git","hg"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's wrong. There are more type of repositories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing ones: composer and package at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
artifact also
|
|
|
The current PR will break the usage of Satis for many cases, as it misses lots of config |
|
Thank you for the feedback @stof, could you please give more some details of the missing areas regarding the config? Regarding the |
|
https://getcomposer.org/doc/05-repositories.md#types Not sure how completely up to date the documentation is, but it should contain everything. |
|
Not sure what to do with this since your PR is also still open @ Composer. /cc @Seldaek can you provide some feedback? See also referenced issue composer/composer#5142 |
Implemented JSON schema update to validate the
tags-pathandbranches-pathconfiguration clauses, also enabled the possibility of using arrays for both path configurations.This Pull Request relates to: #312 and composer/composer#5142