Skip to content

add an "Used In" in the html output#60

Closed
omansour wants to merge 11 commits into
composer:masterfrom
BedrockStreaming:master
Closed

add an "Used In" in the html output#60
omansour wants to merge 11 commits into
composer:masterfrom
BedrockStreaming:master

Conversation

@omansour

@omansour omansour commented Apr 1, 2013

Copy link
Copy Markdown
Contributor

allowing users to see where the package is used

an optional file can be passed to the command to scan extra repos. written quiet quickly.
thanks

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only set in the if () but you use it always in L151.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed txs

squash! avoid notice when no depency file is provided

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fule ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it would be better to use an option IMO

@Seldaek

Seldaek commented Apr 2, 2013

Copy link
Copy Markdown
Member

As far as I understand, this implements #51 right? Ping @oker1.

@oker1

oker1 commented Apr 2, 2013

Copy link
Copy Markdown
Contributor

@Seldaek, yes it seems so.

@omansour

omansour commented Apr 2, 2013

Copy link
Copy Markdown
Contributor Author

please find here an output buid on our private satis

Capture_d cran_02_04_13_21_03

@kennydee

kennydee commented Apr 3, 2013

Copy link
Copy Markdown

👍

1 similar comment
@till

till commented Apr 3, 2013

Copy link
Copy Markdown
Contributor

👍

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy nitpick — but this should go on the previous line.

@omansour

Copy link
Copy Markdown
Contributor Author

hello, is there anything I can do to this this merged ?

is it usefull or not ?

@bretrzaun

Copy link
Copy Markdown

👍

@Seldaek

Seldaek commented Apr 27, 2013

Copy link
Copy Markdown
Member

@omansour sorry for the delay in giving you feedback. It seems good overall (showing dependencies), but I don't quite understand the point of the additional dependency-file argument? What do you use for that? The way I see it it's either an incomplete feature or an unnecessary one.

@omansour

Copy link
Copy Markdown
Contributor Author

@Seldaek no pb :)

the idea behind the dependency-file is to add repos who can appears in the "used in" row but cannot be installed. ie. project that aren't libs or bundle. It's the way i use it at work.

hope it's clear

see u

@Seldaek

Seldaek commented Apr 28, 2013

Copy link
Copy Markdown
Member

Not so clear no, can you give a concrete example? Also can you tell me what exactly goes in this dependency-file? Is it a composer.json of a project, or a list of packages and their requirements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants