add an "Used In" in the html output #60
Conversation
Conflicts: .gitignore
… web output is asked
| if ($input->getArgument('dependency-file')) | ||
| { | ||
| // dependecy | ||
| $dependency = array(); |
There was a problem hiding this comment.
This is only set in the if () but you use it always in L151.
squash! avoid notice when no depency file is provided
| @@ -41,6 +41,7 @@ protected function configure() | |||
| ->setDefinition(array( | |||
| new InputArgument('file', InputArgument::OPTIONAL, 'Json file to use', './satis.json'), | |||
| new InputArgument('output-dir', InputArgument::OPTIONAL, 'Location where to output built files', null), | |||
| new InputArgument('dependency-file', InputArgument::OPTIONAL, 'Json fule to use for scanning dependency', null), | |||
There was a problem hiding this comment.
And it would be better to use an option IMO
|
@Seldaek, yes it seems so. |
|
please find here an output buid on our private satis |
|
👍 |
1 similar comment
|
👍 |
| $packagesDependency = array(); | ||
|
|
||
| if ($input->getArgument('dependency-file')) | ||
| { |
There was a problem hiding this comment.
Crazy nitpick — but this should go on the previous line.
|
hello, is there anything I can do to this this merged ? is it usefull or not ? |
|
👍 |
|
@omansour sorry for the delay in giving you feedback. It seems good overall (showing dependencies), but I don't quite understand the point of the additional dependency-file argument? What do you use for that? The way I see it it's either an incomplete feature or an unnecessary one. |
|
@Seldaek no pb :) the idea behind the dependency-file is to add repos who can appears in the "used in" row but cannot be installed. ie. project that aren't libs or bundle. It's the way i use it at work. hope it's clear see u |
|
Not so clear no, can you give a concrete example? Also can you tell me what exactly goes in this dependency-file? Is it a composer.json of a project, or a list of packages and their requirements? |
|
is the previous screen I gave, m6/distribution-bundle is referenced in a the standard data/satis.json. So my user can add this bundle in their project as usual. You can see that m6/distribution-bundle is used in the package m6/m6info, which is a project (actually http://www.m6info.fr ). m6/m6info is not referenced in data/satis.json but in data/dependency.json (the famous dependency-file called when I build my satis), so it can appear in the used in row but can't be installed via composer here the file I use : regards |
|
hey @Seldaek ! let me know if it's clear or not. regards |
|
@omansour Just curious — can you share why this is necessary? Like, why is the code not installable via composer, or why don't you want to add it to your satis? |
|
hey I have created this PR for the same reasons, I guess, #51 has been created. So my take is that can be helpfull for other people. |
|
OK I merged this minus the --dependency-file, because I really don't see the point of having projects that are not installable as such if you are going to track them with composer somehow anyway. Additionally I added links on the package names so you can quickly go to the package requiring. |
allowing users to see where the package is used
an optional file can be passed to the command to scan extra repos. written quiet quickly.
thanks