Skip to content

add an "Used In" in the html output #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

add an "Used In" in the html output #60

wants to merge 11 commits into from

Conversation

omansour
Copy link
Contributor

@omansour omansour commented Apr 1, 2013

allowing users to see where the package is used

an optional file can be passed to the command to scan extra repos. written quiet quickly.
thanks

if ($input->getArgument('dependency-file'))
{
// dependecy
$dependency = array();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only set in the if () but you use it always in L151.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed txs

squash! avoid notice when no depency file is provided
@@ -41,6 +41,7 @@ protected function configure()
->setDefinition(array(
new InputArgument('file', InputArgument::OPTIONAL, 'Json file to use', './satis.json'),
new InputArgument('output-dir', InputArgument::OPTIONAL, 'Location where to output built files', null),
new InputArgument('dependency-file', InputArgument::OPTIONAL, 'Json fule to use for scanning dependency', null),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fule ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it would be better to use an option IMO

@Seldaek
Copy link
Member

Seldaek commented Apr 2, 2013

As far as I understand, this implements #51 right? Ping @oker1.

@oker1
Copy link
Contributor

oker1 commented Apr 2, 2013

@Seldaek, yes it seems so.

@omansour
Copy link
Contributor Author

omansour commented Apr 2, 2013

please find here an output buid on our private satis

Capture_d cran_02_04_13_21_03

@kennydee
Copy link

kennydee commented Apr 3, 2013

👍

1 similar comment
@till
Copy link
Contributor

till commented Apr 3, 2013

👍

$packagesDependency = array();

if ($input->getArgument('dependency-file'))
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy nitpick — but this should go on the previous line.

@omansour
Copy link
Contributor Author

hello, is there anything I can do to this this merged ?

is it usefull or not ?

@bretrzaun
Copy link

👍

@Seldaek
Copy link
Member

Seldaek commented Apr 27, 2013

@omansour sorry for the delay in giving you feedback. It seems good overall (showing dependencies), but I don't quite understand the point of the additional dependency-file argument? What do you use for that? The way I see it it's either an incomplete feature or an unnecessary one.

@omansour
Copy link
Contributor Author

@Seldaek no pb :)

the idea behind the dependency-file is to add repos who can appears in the "used in" row but cannot be installed. ie. project that aren't libs or bundle. It's the way i use it at work.

hope it's clear

see u

@Seldaek
Copy link
Member

Seldaek commented Apr 28, 2013

Not so clear no, can you give a concrete example? Also can you tell me what exactly goes in this dependency-file? Is it a composer.json of a project, or a list of packages and their requirements?

@omansour
Copy link
Contributor Author

is the previous screen I gave, m6/distribution-bundle is referenced in a the standard data/satis.json. So my user can add this bundle in their project as usual. You can see that m6/distribution-bundle is used in the package m6/m6info, which is a project (actually http://www.m6info.fr ). m6/m6info is not referenced in data/satis.json but in data/dependency.json (the famous dependency-file called when I build my satis), so it can appear in the used in row but can't be installed via composer

here the file I use :

{
    "repositories": [
        { "type": "git", "url": "http://git.m6web.fr/minutefacile.git" },
        { "type": "git", "url": "http://git.m6web.fr/polls.git" },
    { "type": "git", "url": "http://git.m6web.fr/log_debug_center.git" },
        { "type": "git", "url": "http://git.m6web.fr/m6info.git" },
    { "type": "git", "url": "http://git.m6web.fr/backstagev3.git" }        ]
}

regards

@omansour
Copy link
Contributor Author

omansour commented May 2, 2013

hey @Seldaek ! let me know if it's clear or not.

regards
Olivier

@till
Copy link
Contributor

till commented May 25, 2013

@omansour Just curious — can you share why this is necessary?

Like, why is the code not installable via composer, or why don't you want to add it to your satis?

@omansour
Copy link
Contributor Author

hey

I have created this PR for the same reasons, I guess, #51 has been created. So my take is that can be helpfull for other people.

@Seldaek
Copy link
Member

Seldaek commented May 27, 2013

OK I merged this minus the --dependency-file, because I really don't see the point of having projects that are not installable as such if you are going to track them with composer somehow anyway.

Additionally I added links on the package names so you can quickly go to the package requiring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants