improve unit testing and the code coverage #10

Merged
merged 2 commits into from Jan 2, 2017

Projects

None yet

3 participants

@peter279k
Contributor

Change log

  • complete the unit testing.
  • improve the code coverage for this unit testing.

travis-ci status

code coverage report (provided by codecov)

@codecov-io
codecov-io commented Dec 31, 2016 edited

Current coverage is 98.42% (diff: 100%)

No coverage report found for master at 62cf46b.

Powered by Codecov. Last update 62cf46b...287c808

@alcohol

Looks good to me, just one small adjustment please.

.travis.yml
@@ -1,5 +1,7 @@
language: php
+sudo: false
@alcohol
alcohol Jan 2, 2017 Member

This is default, please remove.

@peter279k
peter279k Jan 2, 2017 Contributor

Hi @alcohol , than you for your comment.
I will fix it.

@alcohol
Member
alcohol commented Jan 2, 2017

Thanks.

@alcohol alcohol merged commit b4abc05 into composer:master Jan 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@peter279k
Contributor
peter279k commented Jan 2, 2017 edited

Hi @alcohol , I think the .travis.yml is not merged well...
When I check sudo: false config, it still set this configuration. It need to be modified it manually.
Thanks.

@alcohol
Member
alcohol commented Jan 3, 2017

You are right. It seems to be the case that it was already in the file. Just at a different spot. See https://github.com/peter279k/spdx-licenses/blob/ff0fde2a8445e37c393de753e7ba9103ba776239/.travis.yml#L3-L12

Fixed in 7fc8d83

@peter279k peter279k referenced this pull request in composer/semver Jan 11, 2017
Open

unit testing improvement #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment