From a312e1c5c66bf13db81bd8c07088b51ba48b6320 Mon Sep 17 00:00:00 2001 From: Corina <14900841+corinagum@users.noreply.github.com> Date: Tue, 24 Sep 2019 10:04:03 -0700 Subject: [PATCH] Fix aria-label of Sendbox (#2423) * Fix aria-label of Sendbox * Edit CHANGELOG.md * Add localization * Update CHANGELOG.md Co-Authored-By: TJ Durnford * Update CHANGELOG.md Co-Authored-By: TJ Durnford --- CHANGELOG.md | 1 + packages/component/src/Localization/en-US.js | 1 + packages/component/src/Localization/ja-JP.js | 1 + packages/component/src/SendBox/TextBox.js | 5 +++-- 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bd7978c86c..fd32605ba0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -87,6 +87,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fix [#2365](https://github.com/microsoft/BotFramework-WebChat/issues/2365). Fix Adaptive Card `pushButton` appearance on Chrome, by [@corinagum](https://github.com/corinagum) in PR [#2382](https://github.com/microsoft/BotFramework-WebChat/pull/2382) - Fix [#2379](https://github.com/microsoft/BotFramework-WebChat/issues/2379). Speech synthesis can be configured off by passing `null`, by [@compulim](https://github.com/compulim) in PR [#2408](https://github.com/microsoft/BotFramework-WebChat/pull/2408) - Fix [#2418](https://github.com/microsoft/BotFramework-WebChat/issues/2418). Connectivity status should not waste-render every 400 ms, by [@compulim](https://github.com/compulim) in PR [#2419](https://github.com/microsoft/BotFramework-WebChat/pull/2419) +- Fix [Emulator:#1823](https://github.com/microsoft/BotFramework-Emulator/issues/1823). Fix Sendbox "Type your message" being read twice by AT, by [@corinagum](https://github.com/corinagum) in PR [#2423](https://github.com/microsoft/BotFramework-WebChat/pull/2423) ### Added diff --git a/packages/component/src/Localization/en-US.js b/packages/component/src/Localization/en-US.js index f817bfafad..53b0ddcbf5 100644 --- a/packages/component/src/Localization/en-US.js +++ b/packages/component/src/Localization/en-US.js @@ -79,6 +79,7 @@ export default { Retry: 'Retry', Right: 'Right', Send: 'Send', + SendBox: 'Sendbox', Sending: 'Sending', SendStatus: 'Send status: ', SentAt: 'Sent at: ', diff --git a/packages/component/src/Localization/ja-JP.js b/packages/component/src/Localization/ja-JP.js index d1a5378a26..e053a2435a 100644 --- a/packages/component/src/Localization/ja-JP.js +++ b/packages/component/src/Localization/ja-JP.js @@ -68,6 +68,7 @@ export default { Retry: '再送', Right: '右', Send: '送信', + SendBox: 'テキストボックス', Sending: '送信中', Speak: '話してください', 'Starting…': 'スタート…', diff --git a/packages/component/src/SendBox/TextBox.js b/packages/component/src/SendBox/TextBox.js index 2438535707..3a1ab41e72 100644 --- a/packages/component/src/SendBox/TextBox.js +++ b/packages/component/src/SendBox/TextBox.js @@ -55,6 +55,7 @@ const connectSendTextBox = (...selectors) => const TextBox = ({ className, disabled, language, onChange, onKeyPress, onSubmit, styleSet, value }) => { const typeYourMessageString = localize('Type your message', language); + const sendBoxString = localize('Sendbox', language); const { options: { sendBoxTextWrap } } = styleSet; @@ -69,7 +70,7 @@ const TextBox = ({ className, disabled, language, onChange, onKeyPress, onSubmit {({ sendFocusRef }) => !sendBoxTextWrap ? (