From b48c48f49ffee3f121d4308494bbcb0dbbd4465c Mon Sep 17 00:00:00 2001 From: Corina Date: Thu, 7 Feb 2019 12:45:05 -0800 Subject: [PATCH] Apply suggestions from code review Co-Authored-By: compulim --- CHANGELOG.md | 2 +- __tests__/suggestedActions.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 16d55c9bb0..82f5789872 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -68,7 +68,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - `bundle`: Fix [#1652](https://github.com/Microsoft/BotFramework-WebChat/issues/1652). Pass `pollingInterval` to DirectLineJS constructor, by [@neetu-das](https://github.com/neetu-das) in PR [#1655](https://github.com/Microsoft/BotFramework-WebChat/pull/1655) - `core`: Reworked logic on connect/disconnect for reliability on handling corner cases, by [@compulim](https://github.com/compulim) in PR [#1649](https://github.com/Microsoft/BotFramework-WebChat/pull/1649) - `core`: Fix [#1521](https://github.com/Microsoft/BotFramework-WebChat/issues/1521). Add connectivity status component and update localization, by [@corinagum](https://github.com/corinagum) in PR [#1679](https://github.com/Microsoft/BotFramework-WebChat/pull/1679) -- Fix [#1057](https://github.com/Microsoft/BotFramework-WebChat/issues/1057). Fixed suggested actions destinated for other recipients should not show up, by [@compulim](https://github.com/compulim) in PR [#1706](https://github.com/Microsoft/BotFramework-WebChat/pull/1706) +- Fix [#1057](https://github.com/Microsoft/BotFramework-WebChat/issues/1057). Fixed suggested actions destined for other recipients should not show up, by [@compulim](https://github.com/compulim) in PR [#1706](https://github.com/Microsoft/BotFramework-WebChat/pull/1706) ### Removed - `botAvatarImage` and `userAvatarImage` props, as they are moved inside `styleOptions`, in PR [#1486](https://github.com/Microsoft/BotFramework-WebChat/pull/1486) diff --git a/__tests__/suggestedActions.js b/__tests__/suggestedActions.js index cd029c249e..bc600e1529 100644 --- a/__tests__/suggestedActions.js +++ b/__tests__/suggestedActions.js @@ -149,7 +149,7 @@ describe('suggested-actions command', async () => { expect(base64PNG).toMatchImageSnapshot(imageSnapshotOptions); }, 60000); - test('should not show suggested actions not destinated for the user', async () => { + test('should not show suggested actions not destined for the user', async () => { const { driver, pageObjects } = await setupWebDriver(); await driver.wait(botConnected(), timeouts.directLine);