Brian Norris
computersforpeace

  • Joined on Sep 3, 2012
Jul 6, 2016
Jul 1, 2016
computersforpeace commented on pull request gentoo/gentoo#1811
Jul 1, 2016
computersforpeace commented on pull request gentoo/gentoo#1729
@computersforpeace

Looks like I can't add to this pull request. See new request #1811.

Jul 1, 2016
@computersforpeace
app-text/ghostscript-gpl: fixup the LINGUAS -> L10N changes
1 commit with 10 additions and 10 deletions
Jul 1, 2016
@computersforpeace
Jun 23, 2016
computersforpeace commented on pull request gentoo/gentoo#1729
@computersforpeace

@gentoo/printing

Jun 23, 2016
@computersforpeace
app-text/ghostscript-gpl: add 9.19 ebuild
1 commit with 242 additions and 0 deletions
Jun 23, 2016
Jun 21, 2016
@computersforpeace

Just browsing some code... noticed you might have a bad regex somewhere :)

Jun 16, 2016
@computersforpeace
Jun 15, 2016
computersforpeace opened pull request apple/cups#4841
@computersforpeace
Document cupsd.conf's IdleExitTimeout
1 commit with 14 additions and 0 deletions
Jun 15, 2016
Jun 14, 2016
Jun 14, 2016
May 31, 2016
@computersforpeace

(That's not to say my patch above is great. Dunno if we want a new bool for every little quirk like this, but at least it gets the job done for now…

May 31, 2016
@computersforpeace

BTW, a bugfix patch I'm trying for now: diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c index 5bb0470b01d2..309940a51b0e 10064…

May 31, 2016
@computersforpeace

By dropping this, you're implicitly changing the supported DT binding. If you see below, the existence of this callback causes us to support #pwm-c…

May 31, 2016
@computersforpeace

Quick review: s/1void/Avoid/ in $subject :)

May 31, 2016
computersforpeace commented on pull request apple/cups#4825
@computersforpeace

FYI, I emailed the contributor's agreement last week. Let me know if you have problems with either the CLA or the code.

May 27, 2016
@computersforpeace

checkpatch complained here and elsewhere: WARNING: 'continous' may be misspelled - perhaps 'continuous'? #46: FILE: drivers/regulator/pwm-regulator…

May 27, 2016
@computersforpeace
May 25, 2016
@computersforpeace

The if/else here looks quite asymmetric to me. I understand that really, it is symmetric, but it still feels odd that one side uses dutycycle = ...

May 25, 2016
@computersforpeace

While I'm at it, commenting on your not-yet-posted patches... I think this commit deserves some more thorough explanation about why you're dropping…

May 25, 2016
@computersforpeace

OK, so this additional diff works much better: diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c index 335907118989..fb5677d29a7…

May 25, 2016
@computersforpeace

No, it's not doing the same as you're doing. You have the calculation wrong. You have: div = (clk_rate * period_ns) + (clk_rate / 2); do_div(div, p…

May 25, 2016
@computersforpeace

Haven't tested yet, but I don't think that's a correct "round-closest" implementation... why not just use DIV_ROUND_CLOSEST_ULL() instead anyway? A…

May 24, 2016
@computersforpeace

Do we really need this bit? I'm having problems with the PWM period getting shrunk continually, and it's because of this line. Essentially, we're s…

May 18, 2016
@computersforpeace

Ah, I see. Well yeah, that'd make a better separate commit IMO.

May 17, 2016
@computersforpeace

Since you haven't posted this yet, I'm commenting here... Did you intend to drop the pwm_enable() completely? A pure refactoring would be to still …

May 15, 2016
@computersforpeace