This repository has been archived by the owner on Sep 24, 2019. It is now read-only.
Add option to build the bzip2 library, only #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building for embedded systems, compiling bzip2.c will generally fail due to lack of full POSIX support. The library, libbz2, compiles just fine though, so making the executable part optional enables the library to be used on more platforms.
The new option controls whether to build the bzip2 executable or not. It's called "bzip2:build_executable" and is enabled by default (hence preserving current behavior).
This is my first attempt at modifying a Conan recipe, so I didn't put much thought into polishing and instead wanted to make sure this patch is going in the right direction. I'll happily make adjustments if it's fine though!