Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cccl/1.1 #156

Open
wants to merge 1 commit into
base: master
from

Conversation

@madebr
Copy link
Contributor

commented Oct 1, 2019

Specify library name and version: cccl/1.1

  • This is a build dependency of swig.
    It is used to wrap the visual studio in a gcc like script.

  • port of https://github.com/bincrafters/conan-cccl_installer

  • renamed to cccl (ditched the _installer suffix) (or should this be added?)

  • I've read the guidelines for contributing.

  • I've followed the PEP8 style guides for Python code in the recipes.

  • I've used the latest Conan client version.

  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2019

Some configurations of 'cccl/1.1' have failed:

@madebr madebr force-pushed the madebr:cccl branch 2 times, most recently from 007f7fa to 7edef42 Oct 1, 2019
@conan-center-bot

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2019

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2019

Some configurations of 'cccl/1.1' have failed:

  • Windows x86_64, Debug, Visual Studio 14, MTd
    You are depending on 'msys2_installer/20161025@bincrafters/stable' but it is not in the repository
@madebr madebr force-pushed the madebr:cccl branch from 7edef42 to 6723a9f Oct 1, 2019
@conan-center-bot

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2019

Some configurations of 'cccl/1.1' have failed:

  • Windows x86_64, Debug, Visual Studio 14, MTd
    • Hooks errors detected:
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Package for Header Only does not contain artifacts with these extensions: ['h', 'h++', 'hh', 'hxx', 'hpp'] (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Packaged artifacts does not match the settings used: os=None, compiler=Visual Studio (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs
@madebr madebr force-pushed the madebr:cccl branch from 6723a9f to 0c81a3f Oct 1, 2019
@conan-center-bot

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2019

Some configurations of 'cccl/1.1' have failed:

  • Windows x86_64, Debug, Visual Studio 14, MTd
    • Hooks errors detected:
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Package for Header Only does not contain artifacts with these extensions: ['h', 'h++', 'hh', 'hxx', 'hpp'] (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Packaged artifacts does not match the settings used: os=None, compiler=None (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs
@madebr

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

I don't know how to fix the hook error.
cccl only contains a single shell script without any headers or sources.

imho, https://github.com/conan-io/hooks/blob/a43b4ce00b6f559d19b076e2e670b32222891b61/hooks/conan-center.py#L464 is too broad

@madebr madebr force-pushed the madebr:cccl branch from 0c81a3f to b1dacee Oct 1, 2019
@conan-center-bot

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2019

Some configurations of 'cccl/1.1' have failed:

  • Windows x86_64, Debug, Visual Studio 14, MTd
    • Hooks errors detected:
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Packaged artifacts does not match the settings used: os=Windows, compiler=None (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs
@madebr madebr force-pushed the madebr:cccl branch from b1dacee to 2b5788d Oct 1, 2019
@conan-center-bot

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2019

Some configurations of 'cccl/1.1' have failed:

  • Windows x86_64, Debug, Visual Studio 14, MTd
    • Hooks errors detected:
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Package for Header Only does not contain artifacts with these extensions: ['h', 'h++', 'hh', 'hxx', 'hpp'] (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Packaged artifacts does not match the settings used: os=None, compiler=None (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs
@lasote lasote removed the Unexpected Error label Oct 1, 2019
Copy link
Contributor

left a comment

LGTM

The hook does not expect packages with just a shell script. Either this is something which needs to be allowed in general, or cccl needs to be added to a whitelist

@conan-center-bot

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2019

Some configurations of 'cccl/1.1' have failed:

  • Windows x86_64, Debug, Visual Studio 14, MTd
    • Hooks errors detected:
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Package for Header Only does not contain artifacts with these extensions: ['h', 'h++', 'hh', 'hxx', 'hpp'] (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Packaged artifacts does not match the settings used: os=None, compiler=None (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs
@conan-center-bot

This comment has been minimized.

Copy link
Collaborator

commented Oct 9, 2019

Some configurations of 'cccl/1.1' have failed:

  • Windows x86_64, Debug, Visual Studio 14, MTd
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONAN CENTER INDEX URL (KB-H027)] The attribute 'url' should point to: https://github.com/conan-io/conan-center-index (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H027)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs
@lasote

This comment has been minimized.

Copy link
Collaborator

commented Oct 9, 2019

Hi! I've released some more hooks to check the recipe quality, would you mind to take a look? Thanks!

@madebr madebr force-pushed the madebr:cccl branch from 194ec3f to 2b247b8 Oct 9, 2019
@conan-center-bot

This comment has been minimized.

Copy link
Collaborator

commented Oct 9, 2019

Some configurations of 'cccl/1.1' have failed:

  • Windows x86_64, Debug, Visual Studio 14, MTd
    • Hooks errors detected:
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Package for Header Only does not contain artifacts with these extensions: ['h', 'h++', 'hh', 'hxx', 'hpp'] (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Packaged artifacts does not match the settings used: os=None, compiler=None (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs
@uilianries

This comment has been minimized.

Copy link
Member

commented Oct 18, 2019

This PR is uncommon ... CCCL exports a bash script, however, Conan center hook expects .exe files in /bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.