Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libiconv: apply x86 resource patch #20693

Merged
merged 1 commit into from Dec 26, 2023

Conversation

cyberflashguru
Copy link
Contributor

libiconv/1.17

Create a patch to resolve this x86 libiconv build error:

libiconv.res.obj : fatal error LNK1112: module machine type 'x64' conflicts with target machine type 'x86'

Close #20689

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/libiconv//'.

👋 @Hopobcn you might be interested. 😉

@conan-center-bot

This comment has been minimized.

@RubenRBS RubenRBS changed the title apply x86 resource patch libiconv: apply x86 resource patch Oct 19, 2023
@RubenRBS RubenRBS self-assigned this Oct 19, 2023
@RubenRBS
Copy link
Member

Hi @Subash-Lamichhane thanks a lot for your contribution! Make sure to submit access in the request access issue for the PR to be able to get merged, thanks!

@conan-center-bot

This comment has been minimized.

@docbrown1955
Copy link

Hello, any news on this PR ? I encountered the same issue with libiconv.

@uilianries
Copy link
Member

Friendly ping @cyberflashguru ! We want to accept your PR, but first you need to be listed in the allowed users list. Could please ask for access in the issue #4

More information about CCI process: https://github.com/conan-io/conan-center-index/tree/master/docs/adding_packages#one-request-access

@uilianries
Copy link
Member

@docbrown1955 Currently, this PR is blocked due authorization. In case the author does not want to continue, you could open a second PR with same changes.

@cyberflashguru
Copy link
Contributor Author

cyberflashguru commented Nov 16, 2023

@docbrown1955 Currently, this PR is blocked due authorization. In case the author does not want to continue, you could open a second PR with same changes.

Added myself here: #4 (comment)

@cyberflashguru
Copy link
Contributor Author

Hi @Subash-Lamichhane thanks a lot for your contribution! Make sure to submit access in the request access issue for the PR to be able to get merged, thanks!

Who is @Subash-Lamichhane? Did you mean cyberflashguru? Thanks.

@docbrown1955
Copy link

@docbrown1955 Currently, this PR is blocked due authorization. In case the author does not want to continue, you could open a second PR with same changes.

@uilianries Thanks, although it seems good now ?

@uilianries
Copy link
Member

@cyberflashguru Thank you for your fix! Have you communicated the upstream about that bug? Please, inform the upstream about the case, so we don't need to patch future versions too.

In https://www.gnu.org/software/libiconv/ you can find:

Bug reports
Bug reports should be sent to bug-gnu-libiconv@gnu.org.

@cyberflashguru
Copy link
Contributor Author

@uilianries
Copy link
Member

@cyberflashguru Thank you for reporting the upstream!

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (977ffbcb0a35bd0c7c88dfbb17d8abdd77795446):

  • libiconv/1.17:
    All packages built successfully! (All logs)

  • libiconv/1.16:
    All packages built successfully! (All logs)

  • libiconv/1.15:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (977ffbcb0a35bd0c7c88dfbb17d8abdd77795446):

  • libiconv/1.17:
    All packages built successfully! (All logs)

  • libiconv/1.16:
    All packages built successfully! (All logs)

  • libiconv/1.15:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 56d6683 into conan-io:master Dec 26, 2023
24 checks passed
valgur pushed a commit to valgur/conan-center-index that referenced this pull request Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants