New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libiconv: apply x86 resource patch #20693
Conversation
|
🤖 Beep Boop! This pull request is making changes to 'recipes/libiconv//'. 👋 @Hopobcn you might be interested. 😉 |
This comment has been minimized.
This comment has been minimized.
|
Hi @Subash-Lamichhane thanks a lot for your contribution! Make sure to submit access in the request access issue for the PR to be able to get merged, thanks! |
This comment has been minimized.
This comment has been minimized.
|
Hello, any news on this PR ? I encountered the same issue with libiconv. |
|
Friendly ping @cyberflashguru ! We want to accept your PR, but first you need to be listed in the allowed users list. Could please ask for access in the issue #4 More information about CCI process: https://github.com/conan-io/conan-center-index/tree/master/docs/adding_packages#one-request-access |
|
@docbrown1955 Currently, this PR is blocked due authorization. In case the author does not want to continue, you could open a second PR with same changes. |
Added myself here: #4 (comment) |
Who is @Subash-Lamichhane? Did you mean cyberflashguru? Thanks. |
@uilianries Thanks, although it seems good now ? |
|
@cyberflashguru Thank you for your fix! Have you communicated the upstream about that bug? Please, inform the upstream about the case, so we don't need to patch future versions too. In https://www.gnu.org/software/libiconv/ you can find: |
|
Added a bug report to bug-gnu-libiconv@gnu.org. Thanks. |
|
@cyberflashguru Thank you for reporting the upstream! |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 5 (
Conan v2 pipeline ✔️
All green in build 3 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
libiconv/1.17
Create a patch to resolve this x86 libiconv build error:
libiconv.res.obj : fatal error LNK1112: module machine type 'x64' conflicts with target machine type 'x86'Close #20689