Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getopt-for-visual-studio/20200201 recipe #877

Merged
merged 3 commits into from Mar 6, 2020
Merged

Add getopt-for-visual-studio/20200201 recipe #877

merged 3 commits into from Mar 6, 2020

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Feb 14, 2020 •
edited

Specify library name and version: getopt-for-visual-studio/20200201

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

All green in build 1 (685f94253e9a8a2cae9c3724c2d74d6bfe381f98)! 😊

  • getopt-for-visual-studio/20200201: Generated 1 packages. All logs here

@conan-center-bot
Copy link
Collaborator

All green in build 2 (80fac5a589244b303e89037ccd44a2a4f3dcf843)! 😊

  • getopt-for-visual-studio/20200201: Generated 1 packages. All logs here

SSE4
SSE4 previously approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very useful library for porting GNU stuff to MSVC. thanks for the contribution!

@SSE4 SSE4 requested a review from uilianries February 20, 2020 11:28
uilianries
uilianries requested changes Feb 20, 2020
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few adjusts, but it looks good

recipes/getopt-for-visual-studio/all/conanfile.py Outdated Show resolved Hide resolved
recipes/getopt-for-visual-studio/all/conanfile.py Show resolved Hide resolved
@madebr @uilianries
getopt-for-visual-studio: fix homepage
ff20a3f 
Co-Authored-By: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

All green in build 3 (ff20a3f292bf2b6f1f6494a8e1ef2f73f3f16a3b)! 😊

  • getopt-for-visual-studio/20200201: Generated 1 packages. All logs here

@madebr madebr requested a review from SSE4 February 22, 2020 12:57
SSE4
SSE4 approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved again

@madebr
Copy link
Contributor Author

madebr commented Feb 26, 2020

@danimtb Please consider merging this one. ☺️

@madebr madebr mentioned this pull request Feb 28, 2020
Merged
4 tasks
@danimtb
Copy link
Member

danimtb commented Mar 3, 2020 •
edited

Should we have this library when there is a clear deprecation notice at the author's repo?

https://github.com/skandhurkat/Getopt-for-Visual-Studio#deprication-notice

Are the alternatives suggested not good enough for the purpose that this library covers?

@madebr
Copy link
Contributor Author

madebr commented Mar 3, 2020

@danimtb
Of course, the notics says to not use it in NEW libraries.
But older, mostly unix, libraries still use it.

@danimtb danimtb self-assigned this Mar 5, 2020
@conan-center-bot
Copy link
Collaborator

All green in build 5 (ff20a3f292bf2b6f1f6494a8e1ef2f73f3f16a3b)! 😊

  • getopt-for-visual-studio/20200201: Generated 1 packages. All logs here

@danimtb danimtb merged commit 34f9876 into conan-io:master Mar 6, 2020
@madebr madebr deleted the getopt_msvc branch March 6, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@uilianries uilianries uilianries approved these changes

@danimtb danimtb danimtb approved these changes

Assignees

@danimtb danimtb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@madebr @conan-center-bot @danimtb @SSE4 @uilianries