Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#50 Windows support #61

Open
wants to merge 100 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@uilianries
Copy link
Member

uilianries commented Oct 10, 2018

Hi!

This PR is huge, so take a coffee ☕️

  • Add Windows docker recipes including MSVC 14.0 and MSVC 15.0
  • Update GTest package version to 1.8.1
  • Add usage example with Windows containers

I can't figure out how to create a MSVC 12.0 version. Croydon helped me with some choco packages for visual studio 2013 but didn't work.

I'll not build the Windows images since we can not break the license agreement.

fixes #50

uilianries added some commits Oct 3, 2018

#50 Add partial Appveyor info
- Add Visual Studio 14 on README

Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Build Visual Studio 14
- Add conanmsvc14 image
- Update docker compose to build windows image
- Update build script to support Windows

Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Add Appveyor recipe
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Fix sudo command
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Add Visual on compiler list
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Add Visual on compiler list
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Skip linter on Windows
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Escape line break on Windows
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Change Windows base image
- Appveyor does not support core 8.x

Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Change temp path on Windows build
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Install CMake using chocolatey
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Upgrade pip on Windows image
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Update MSVC 14 install
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Build MSVC 14 on Appveyor
- It's not possible to upload Docker image by Appveyor because the
  image is huge >10GB. Error from Appveyor:
  "Build exceeded allowed resource quotas. Fix your build to consume
   less resources or contact AppVeyor support to request quotas
   increase."

Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Update Windows base image
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 show windows image size
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Use pretty name on tests
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 print docker images after to finish
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Update MSVC14
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Build Visual Studio 15
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Build Windows images on Azure
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Add Visual Studio 12.0
- Add Docker image based on Visual Studio 2013 12.0

Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Install pip packages quietly
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 update msvc12 package
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 update msvc12 package
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 update msvc12 package [skip travis]
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Remove MSVC 12 from builds
- I can't figure out some way to istall msvc 12

Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Add MSVC 12 again
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Install IE10 to fix MSVC2013
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Update docker image for Clang 7
Signed-off-by: Uilian Ries <uilianries@gmail.com>

@uilianries uilianries referenced this pull request Nov 9, 2018

Open

Support Azure CI templates #3678

2 of 3 tasks complete
@uilianries

This comment has been minimized.

Copy link
Member Author

uilianries commented Nov 12, 2018

Related issue: conan-io/conan#3678

@uilianries

This comment has been minimized.

Copy link
Member Author

uilianries commented Nov 27, 2018

I opened a discussion in visual studio community to get some help from Azure side. Please, upvote.

https://developercommunity.visualstudio.com/content/problem/392600/could-not-build-docker-image-windowsservercodre-on.html

uilianries added some commits Dec 11, 2018

#50 Change to windows 1803
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Change to windows VS2017
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Change to windows lts2016 [skip travis]
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Dont timeout msvc install
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Split MSVC steps [skip travis]
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@@ -0,0 +1 @@
docker build --no-cache --target msvc14 -t conanio/msvc14 .

This comment has been minimized.

@monsdar

monsdar Dec 20, 2018

The given --target is not part of the Dockerfile

uilianries added some commits Jan 2, 2019

#50 Set storage container size to 20GB [skip travis]
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Set container size in docker config file [skip travis]
- Docker Composer 3.x doesn't support storage_size
  option.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 print vars [skip travis]
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Print daemon json file [skip travis]
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Force storage size [skip travis]
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Force storage size to 20GB [skip travis]
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Set container size to 50GB [skip travis]
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Try to build on Appveyor [skip travis]
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries

This comment has been minimized.

Copy link
Member Author

uilianries commented Mar 12, 2019

@Croydon Do you know if is it possible to distribute the Docker recipe at least? I won't upload the Docker image.

@uilianries uilianries changed the title [WIP] #50 Windows support #50 Windows support Mar 12, 2019

#50 Remove Windows from Azure
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@Croydon
Copy link
Contributor

Croydon left a comment

Taken back my approval as we discovered that Microsoft doesn't allow legally to distribute Visual Studio in any way. If we upload Docker images with an installed Visual Studio we would infringe these rules.

@Croydon

This comment has been minimized.

Copy link
Contributor

Croydon commented Mar 13, 2019

@uilianries Distributing the Docker recipe(s) is fine. We are just not allowed to distribute any Visual Studio files/installers

@uilianries

This comment has been minimized.

Copy link
Member Author

uilianries commented Mar 13, 2019

@Croydon Thanks for explaining this.

uilianries added some commits Mar 13, 2019

#50 Fix Azure pipeline file
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Remove Travis CI support [skip ci]
- Only support Azure for now

Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Remove extra scripts
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Revert docker compose
Signed-off-by: Uilian Ries <uilianries@gmail.com>
#50 Fix CI badge
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.