Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conan info graph output to html should include local versions of vis library #3667

Closed
3 tasks done
chrahunt opened this issue Oct 6, 2018 · 3 comments
Closed
3 tasks done

conan info graph output to html should include local versions of vis library #3667

chrahunt opened this issue Oct 6, 2018 · 3 comments
Assignees
@memsharded
Labels
complex: low priority: low type: feature
Milestone
1.11

Comments

@chrahunt
Copy link
Contributor

chrahunt commented Oct 6, 2018 •
edited

Conan version: 1.7.4

When running conan info -g foo.html . to generate a dependency graph, the generated HTML includes hard-coded links to cdnjs for vis.min.js and vis.min.css:

<head>
  <script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/vis/4.18.1/vis.min.js"></script>
  <link href="https://cdnjs.cloudflare.com/ajax/libs/vis/4.18.1/vis.min.css" rel="stylesheet" type="text/css" />
</head>

In a corporate environment users may not have access to these URLs so the generated file is not useful. It would be nice if we could package these files in conan itself and output them alongside the generated html file if requested (via command-line flag, for example).

To help us debug your issue please explain:

  • I've read the CONTRIBUTING guide.
  • I've specified the Conan version, operating system version and any tool that can be relevant.
  • I've explained the steps to reproduce the error or the motivation/use case of the question/suggestion.
@memsharded memsharded added this to the 1.9 milestone Oct 7, 2018
@memsharded
Copy link
Member

I think it is doable, but feels a bit dirty. But yes, I understand the use case.
The implementation (packaging and distributing those files), needs to check for license compatibility, and it might be a bit dirty to package the files. But embedding the strings in python files is always possible, so they could directly be embedded in the html file, so it is self-contained.

To be discussed for 1.9.

@memsharded memsharded assigned memsharded and unassigned memsharded Oct 9, 2018
@memsharded
Copy link
Member

memsharded commented Oct 9, 2018 •
edited

Seems the simplest and most effective is to embed them as strings in py files.

Please check the LICENSES of the JS and CSS

@memsharded memsharded removed the to do label Oct 23, 2018
@lasote lasote modified the milestones: 1.9, 1.10 Oct 29, 2018
@lasote lasote removed this from the 1.10 milestone Nov 19, 2018
@jgsogo jgsogo mentioned this issue Dec 4, 2018
Closed
@memsharded memsharded mentioned this issue Dec 14, 2018
Merged
@memsharded
Copy link
Member

memsharded commented Dec 14, 2018 •
edited

Hi @chrahunt

I have submitted a PR #4133 for this.
The problem is embedding the vis library resources, it is more problematic than it should be (taking into account also the different ways conan is distributed). So I have proposed to workaround it by letting users provide their own vis.js resources in the local conan cache, so they can be installed with conan config install.

I hope this helps.

@memsharded memsharded added this to the 1.11 milestone Dec 14, 2018
@memsharded memsharded self-assigned this Dec 14, 2018
@ghost ghost removed the stage: queue label Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@memsharded memsharded

Labels
complex: low priority: low type: feature
Projects
None yet
Milestone
1.11
Development

No branches or pull requests
3 participants
@chrahunt @lasote @memsharded