Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[conan.tools.cmake] Modernized add_definitions #10974

Merged
merged 3 commits into from Apr 5, 2022
Merged

[conan.tools.cmake] Modernized add_definitions #10974

merged 3 commits into from Apr 5, 2022

Conversation

franramirez688
Copy link
Contributor

@franramirez688 franramirez688 commented Apr 5, 2022 •
edited by czoido

Changelog: Feature: Replaced add_definitions by add_compile_definitions in conan.tools.cmake.* package.
Docs: omit

Closes: #10929

Note: conan.tools.cmake.* is already using CMake >= 3.15 and add_compile_definitions requires >= 3.12.

@franramirez688 franramirez688 added this to the 1.48 milestone Apr 5, 2022
@franramirez688 franramirez688 merged commit 2550445 into conan-io:develop Apr 5, 2022
@SeanSnyders
Copy link

Please check #11043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasote lasote lasote approved these changes

@memsharded memsharded memsharded approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
1.48
Development

Successfully merging this pull request may close these issues.

[feature] Modernize add_definitions
5 participants
@franramirez688 @SeanSnyders @lasote @memsharded @czoido