Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix trait visible for build requires #15357

Merged
merged 1 commit into from
Jan 2, 2024
Merged

fix trait visible for build requires #15357

merged 1 commit into from
Jan 2, 2024

Conversation

memsharded
Copy link
Member

Changelog: Bugfix: Fix visible trait propagation with build=True trait.
Docs: Omit

Close #15346

@memsharded memsharded added this to the 2.0.17 milestone Dec 27, 2023
@AbrilRBS
Copy link
Member

AbrilRBS commented Dec 28, 2023 •
edited
Loading

Quick question: When did this break? Was it introduced in 2.0.15?

@memsharded
Copy link
Member Author

Quick question: When did this break? Was it introduced in 2.0.15?

It never worked. The use case is subtle:

  • Using a build=True trait, but with a normal require, making it visible=True, which is a very corner case, should probably be avoided for most cases
  • Mixing visible=False with the above build=True + visible=True

So this case was not covered by tests.

@memsharded memsharded mentioned this pull request Dec 28, 2023
Closed
1 task
@memsharded memsharded merged commit f734566 into conan-io:release/2.0 Jan 2, 2024
2 checks passed
@memsharded memsharded deleted the fix/trait_build_visible branch January 2, 2024 10:34
@maximilianmuehlbauer maximilianmuehlbauer mentioned this pull request Jun 28, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.17
Development

Successfully merging this pull request may close these issues.
2 participants
@memsharded @AbrilRBS