Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Removed client-side username checks (#3444) #3464
Fairly simple fix I think, just removing the client side tests when authenticating with the server. An error will still be raised iff the server determines the username to be invalid, but client side checks are no longer in place. This means that it's completely at the discretion of the server to decide whether or not a username is valid or invalid.
As I mentioned in #3444, the client side checks made it impossible to authenticate with an Artifactory instance using SAML SSO using the prompts in
Changelog: Fix: Removed login username syntax checks that were no longer necessary.
memsharded left a comment
The implementation now seems correct. However, to make it a complete change, it would be necessary:
The first two are easy, just remove them. The last one might be a bit more complicated, but the