Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Git class, wrongly replacing characters from the branch name #3496

Merged
merged 1 commit into from Sep 6, 2018

Conversation

Projects
None yet
3 participants
@lasote
Copy link
Contributor

commented Sep 6, 2018

The Git get_branch method has to return the branch name, the responsibility of adapting it to be used as a version is not from the Git class. @niosHD The test has been updated to reflect how it can be used now.

Changelog: Fix: Fixed Git scm class avoiding to replace any character in the get_branch() function.

@lasote lasote added this to the 1.8 milestone Sep 6, 2018

@lasote lasote requested review from jgsogo, danimtb and memsharded Sep 6, 2018

@ghost ghost assigned lasote Sep 6, 2018

@ghost ghost added the stage: review label Sep 6, 2018

@jgsogo jgsogo referenced this pull request Sep 6, 2018

Merged

Implementation of SCM feature for SVN #3192

12 of 12 tasks complete
@danimtb

danimtb approved these changes Sep 6, 2018

@memsharded memsharded merged commit d8e068f into conan-io:develop Sep 6, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Sep 6, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Merge pull request conan-io#3496 from lasote/feature/clean_git_get_br…
…anch

Fixed Git class, wrongly replacing characters from the branch name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.