Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing processing of exports exclude patterns #3537

Merged
merged 3 commits into from Sep 17, 2018

Conversation

@memsharded
Copy link
Member

@memsharded memsharded commented Sep 12, 2018

Close #3535
Close #3258
Close #3409

Changelog: Bugfix: Fixed export_sources excluded patterns containing symlinks.

@ghost ghost assigned memsharded Sep 12, 2018
@ghost ghost added the stage: review label Sep 12, 2018
@memsharded memsharded requested a review from danimtb Sep 13, 2018
@memsharded memsharded assigned lasote and unassigned memsharded Sep 13, 2018
@memsharded memsharded added this to the 1.8 milestone Sep 13, 2018
@ghost ghost assigned memsharded Sep 13, 2018
Copy link
Member

@danimtb danimtb left a comment

If this closes my PR monstrosity then I am relieved 😆

lasote
lasote approved these changes Sep 17, 2018
Copy link
Contributor

@lasote lasote left a comment

I wouldn't understand this code in a reasonable amount of time, so as it appears to be tested, go ahead.

@memsharded memsharded merged commit e9e3de2 into conan-io:develop Sep 17, 2018
2 checks passed
@ghost ghost removed the stage: review label Sep 17, 2018
@memsharded memsharded deleted the feature/export_exclude branch Sep 17, 2018
grisumbras pushed a commit to grisumbras/conan that referenced this issue Dec 27, 2018
changing processing of exports exclude patterns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment