Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "conanfile not found" message #3554

Merged

Conversation

Projects
None yet
3 participants
@sigiesec
Copy link
Contributor

commented Sep 14, 2018

Fixes #3553

Changelog: Fix: Improve error messages if conanfile was not found

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one. Also adding a description of the changes in the changelog.rst file. https://github.com/conan-io/docs

@ghost ghost added the contributor pr label Sep 14, 2018

@sigiesec sigiesec force-pushed the sigiesec:improve-conanfile-not-found-message branch 2 times, most recently from b2c4a13 to 39aa9e8 Sep 14, 2018

sigiesec added a commit to sigiesec/docs that referenced this pull request Sep 14, 2018

@sigiesec sigiesec force-pushed the sigiesec:improve-conanfile-not-found-message branch from 39aa9e8 to 80abf12 Sep 14, 2018

@sigiesec sigiesec changed the title [WiP] Improve "conanfile not found" message Improve "conanfile not found" message Sep 14, 2018

@lasote

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2018

LGTM, not sure about the given message error, but it is just a little detail. I'm assigning to 1.9 because of 1.8 is already huge and we are already late. Many thanks!

@lasote lasote added this to the 1.9 milestone Sep 17, 2018

@memsharded memsharded merged commit f9f8eca into conan-io:develop Oct 19, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the contributor pr label Oct 19, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Merge pull request conan-io#3554 from sigiesec/improve-conanfile-not-…
…found-message

Improve "conanfile not found" message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.