Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't retry when NotFoundException #3562

Merged
merged 1 commit into from Sep 17, 2018

Conversation

Projects
None yet
2 participants
@lasote
Copy link
Contributor

commented Sep 17, 2018

Currently, with APIv2 it is retrying the download when a file doesn't exist. It should retry only if there is another kind of error.

Changelog: Bugfix: Apiv2 was retrying the downloads even when a 404 error was raised.

@ghost ghost assigned lasote Sep 17, 2018

@ghost ghost added the stage: review label Sep 17, 2018

@lasote lasote added this to the 1.8 milestone Sep 17, 2018

@memsharded memsharded merged commit e0fa691 into conan-io:develop Sep 17, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Sep 17, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Merge pull request conan-io#3562 from lasote/feature/do_not_retry_whe…
…n_404

Don't retry when NotFoundException
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.