Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bottle as dev requirement #3646

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
3 participants
@danimtb
Copy link
Member

commented Oct 1, 2018

After running some test from a clean python environment I realized bottle was not installed.

Changelog: Fix: Included bottle package in the development requirements

@danimtb danimtb added this to the 1.8 milestone Oct 1, 2018

@ghost ghost assigned danimtb Oct 1, 2018

@ghost ghost added the stage: review label Oct 1, 2018

@lasote

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2018

The Changelog line should be: "Changelog: Fix: Included bottle package in the development requirements"

@danimtb

This comment has been minimized.

Copy link
Member Author

commented Oct 1, 2018

Tests in CI where working OK because bottle is installed in the requirements_server.txt so maybe this is not needed as our readme says:

Running the tests
Install python requirements

$ pip install -r conans/requirements.txt
$ pip install -r conans/requirements_server.txt
$ pip install -r conans/requirements_dev.txt

@lasote

lasote approved these changes Oct 1, 2018

@danimtb danimtb removed their assignment Oct 1, 2018

@memsharded memsharded merged commit acd821c into conan-io:develop Oct 1, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Oct 1, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.