Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reuse python requires exports #3661

Merged

Conversation

Projects
None yet
2 participants
@memsharded
Copy link
Contributor

commented Oct 2, 2018

Changelog: Feature: Implement reusage of sources (exports_sources) in recipes used as python_requires().

  • Refer to the issue that supports this Pull Request.
    Close #3538

Proposes to reuse source code from base python_requires, that can be exports_sources to the inheriting conanfiles

@memsharded memsharded added this to the 1.9 milestone Oct 2, 2018

@ghost ghost assigned memsharded Oct 2, 2018

@ghost ghost added the stage: review label Oct 2, 2018

@memsharded memsharded assigned lasote and unassigned memsharded Oct 11, 2018

@lasote
Copy link
Contributor

left a comment

Looks good but:

  • Solve conflicts
  • It deserves some docs in the python requires section explaining well the behavior. Probably the SCM behavior should be there.

@ghost ghost assigned memsharded Oct 26, 2018

@lasote lasote merged commit 085c014 into conan-io:develop Oct 26, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Oct 26, 2018

@lasote

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2018

Created issue in the docs to recall it.

@memsharded memsharded deleted the memsharded:feature/reuse_python_requires_exports branch Oct 26, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Feature/reuse python requires exports (conan-io#3661)
* reuse python requires exports

* doing only copy of exports_sources for building

* new test to check python requires class attrs

* complete_source and export instead of copy

* more checks

* format

* fixing tests

* fix broken test

* ready for revision
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.