Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: propagation of options with value None upstream #3684

Merged
merged 5 commits into from Oct 8, 2018

Conversation

Projects
None yet
3 participants
@jgsogo
Copy link
Member

commented Oct 8, 2018

Changelog: Fix: None option value was not being propagated upstream in the dependency graph

@ghost ghost assigned jgsogo Oct 8, 2018

@ghost ghost added the stage: review label Oct 8, 2018

@memsharded
Copy link
Contributor

left a comment

Seems a very good catch.
Could you please write a test that would fail without this change? Thx!

@jgsogo jgsogo assigned memsharded and unassigned jgsogo Oct 8, 2018

@lasote lasote added this to the 1.8 milestone Oct 8, 2018

@lasote lasote merged commit 01e3121 into conan-io:develop Oct 8, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Oct 8, 2018

@jgsogo jgsogo deleted the jgsogo:issue/3407 branch Oct 8, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Fix: propagation of options with value None upstream (conan-io#3684)
* fix comparaison with None (conan-io#3407)

* better logic

* same as previous committed code

* add tests for one use case

* add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.