Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3671 Add attribute tags #3702

Merged
merged 6 commits into from Oct 24, 2018
Merged

Conversation

@uilianries
Copy link
Member

@uilianries uilianries commented Oct 9, 2018

Changelog: Feature: Added topics attribute to the ConanFile to specify topics (a.k.a tags, a.k.a keywords) to the recipe.

This PR is related to #3671

Also, I added author as default attribute when running conan new

Docs PR: conan-io/docs#875

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.
@ghost ghost added the contributor pr label Oct 9, 2018
@memsharded memsharded added this to the 1.9 milestone Oct 9, 2018
jgsogo
jgsogo approved these changes Oct 10, 2018
conans/client/cmd/new.py Outdated Show resolved Hide resolved
uilianries added 5 commits Oct 22, 2018
- Support new attribute on Conafile: tags

Signed-off-by: Uilian Ries <uilianries@gmail.com>
- Validate both inspect and info commands using tags
  as attribute

Signed-off-by: Uilian Ries <uilianries@gmail.com>
- Fix attribute order to validate inspect command

Signed-off-by: Uilian Ries <uilianries@gmail.com>
- We believe that topics is a better name, because tags remember svn
  and git features.
- We voted also for labels but topics sounds better.
- Thanks to @SSE4 for 'topics'

Signed-off-by: Uilian Ries <uilianries@gmail.com>
- Homepage is optional but will be listed by info and inspect
  commands
- Update unit tests to validate homepage
- Update topics to be used as tuple

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries force-pushed the feature/attribute-tags branch from 5a64a34 to 7a90b4f Oct 22, 2018
@uilianries
Copy link
Member Author

@uilianries uilianries commented Oct 22, 2018

@danimtb
Copy link
Member

@danimtb danimtb commented Oct 23, 2018

Relaunched CI

@jgsogo
Copy link
Member

@jgsogo jgsogo commented Oct 23, 2018

This is adding topics and homepage, it should be mentioned in the changelog and maybe documented, shouldn't it?

@uilianries
Copy link
Member Author

@uilianries uilianries commented Oct 23, 2018

There is a PR related to topics on conan-io/docs but I don't know how to proceed about changelog

@jgsogo
Copy link
Member

@jgsogo jgsogo commented Oct 24, 2018

We generate the changelog for a version automatically by parsing all the PRs that are merged into that version, our script takes the Changelog: (Feature|Fix|Bugfix): whatever line in the first comment.

@uilianries
Copy link
Member Author

@uilianries uilianries commented Oct 24, 2018

nice 👍

conans/test/command/info_test.py Outdated Show resolved Hide resolved
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@memsharded memsharded merged commit fd456eb into conan-io:develop Oct 24, 2018
2 checks passed
@ghost ghost removed the contributor pr label Oct 24, 2018
grisumbras pushed a commit to grisumbras/conan that referenced this issue Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants