Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show cpp_info in output from install and create commands #3717

Merged
merged 3 commits into from Oct 18, 2018

Conversation

Projects
None yet
3 participants
@jgsogo
Copy link
Member

commented Oct 10, 2018

Changelog: Feature: Add cpp_info data to json output of install andcreate commands at package level.

Output looks like this:

{
    "error": false,
    "installed": [
        {
            "recipe": {
                "id": "zlib/1.2.11@conan/stable",
                "name": "zlib",
                "version": "1.2.11",
                "user": "conan",
                "channel": "stable",
                "downloaded": false,
                "cache": true,
                "error": null,
                "remote": null,
                "time": "2018-10-10T10:28:28.351753",
                "dependency": true
            },
            "packages": [
                {
                    "id": "0eaf3bfbc94fb6d2c8f230d052d75c6c1a57a4ce",
                    "downloaded": false,
                    "cache": true,
                    "error": null,
                    "remote": null,
                    "time": "2018-10-10T10:28:28.356103",
                    "built": false,
                    "cpp_info": {
                        "includedirs": [
                            "include"
                        ],
                        "libdirs": [
                            "lib"
                        ],
                        "resdirs": [
                            "res"
                        ],
                        "bindirs": [
                            "bin"
                        ],
                        "builddirs": [
                            ""
                        ],
                        "libs": [
                            "z"
                        ],
                        "rootpath": "/Users/jgsogo/.conan/data/zlib/1.2.11/conan/stable/package/0eaf3bfbc94fb6d2c8f230d052d75c6c1a57a4ce",
                        "version": "1.2.11",
                        "description": "A Massively Spiffy Yet Delicately Unobtrusive Compression Library (Also Free, Not to Mention Unencumbered by Patents)"
                    }
                }
            ]
        }
    ]
}

Work to be done, don't know if it is for this PR:

  • remove version and description from cpp_info, so it won't appear at the packages level.

@ghost ghost assigned jgsogo Oct 10, 2018

@ghost ghost added the stage: review label Oct 10, 2018

@jgsogo jgsogo changed the title Show cpp_info in output from install, create and info commands Show cpp_info in output from install and create commands Oct 10, 2018

@jgsogo jgsogo requested a review from lasote Oct 11, 2018

@jgsogo jgsogo referenced this pull request Oct 11, 2018

Closed

Log cpp_info as json in conan outputs #3641

3 of 3 tasks complete

@jgsogo jgsogo added this to the 1.9 milestone Oct 16, 2018

@danimtb
Copy link
Member

left a comment

Please update de output example down below to reflect the changes and mostly to get an example of the cpp_info

@jgsogo

This comment has been minimized.

Copy link
Member Author

commented Oct 16, 2018

The output is already updated with the name, version,... fields

@danimtb

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

Sorry, my comment above was for the docs PR 🙂

@lasote

lasote approved these changes Oct 17, 2018

@danimtb

This comment has been minimized.

Copy link
Member

commented Oct 18, 2018

  • remove version and description from cpp_info, so it won't appear at the packages level.

Please create the issue for this

@lasote lasote merged commit 24a439c into conan-io:develop Oct 18, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Oct 18, 2018

@jgsogo jgsogo deleted the jgsogo:issue/3641 branch Oct 18, 2018

@jgsogo

This comment has been minimized.

Copy link
Member Author

commented Oct 19, 2018

remove version and description from cpp_info, so it won't appear at the packages level.

Please create the issue for this

@danimtb There is some work already done in this direction, I have this PR as an intermediate step (#3733), a branch in my repo 😉 (https://github.com/jgsogo/conan/tree/issue/3641-version-description) and I've just opened the issue #3797. On my way!

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Show cpp_info in output from install and create commands (conan-io#3717)
* show cpp_info in output from install, create and info

* add tests

* add fields name, version, user, channel and revision to 'recipe' field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.