Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yum update without confirmation. #3747

Merged
merged 3 commits into from Oct 15, 2018

Conversation

Projects
None yet
5 participants
@yangcha
Copy link
Contributor

commented Oct 14, 2018

Changelog: Bugfix: yum update needs user's confirmation, which breaks system update in Centos non-interactive terminal.

  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@ghost ghost added the contributor pr label Oct 14, 2018

@CLAassistant

This comment has been minimized.

Copy link

commented Oct 14, 2018

CLA assistant check
All committers have signed the CLA.

yangcha added some commits Oct 14, 2018

@Croydon

This comment has been minimized.

Copy link
Contributor

commented Oct 14, 2018

I had the same problem on Fedora. However, I'm wondering if there is a way to ask for confirmation and to continue successful if the answer is yes? It's not really good when you install some Conan dependency and your system is getting changed automatically.

@memsharded

This comment has been minimized.

Copy link
Contributor

commented Oct 14, 2018

Hi @yangcha

Thanks for contributing this! I think it makes sense.

@Croydon

It's not really good when you install some Conan dependency and your system is getting changed automatically.

Yeah, I know, but this is the current design of SystemPackageTool. When a package recipe decides to use it to install something, is because it needs those packages to operate. It might be possible to ask the user for confirmation, but then such recipe will not work. And making it the default is kind of impossible without breaking a ton of things. So I think we are good merging this PR.

@memsharded memsharded added this to the 1.9 milestone Oct 14, 2018

@yangcha

This comment has been minimized.

Copy link
Contributor Author

commented Oct 14, 2018

Hi @yangcha

Thanks for contributing this! I think it makes sense.

@Croydon

It's not really good when you install some Conan dependency and your system is getting changed automatically.

Yeah, I know, but this is the current design of SystemPackageTool. When a package recipe decides to use it to install something, is because it needs those packages to operate. It might be possible to ask the user for confirmation, but then such recipe will not work. And making it the default is kind of impossible without breaking a ton of things. So I think we are good merging this PR.

@memsharded This is what I want to say about. In fact, install() does not ask user for confirmation, either.
@Croydon If user confirmation is really important to you, there is a way to implement it:
you can use if os.isatty(0): to check if the terminal is interactive or not, then add -y if it is non-interactive terminal.

@lasote lasote merged commit 650688f into conan-io:develop Oct 15, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the contributor pr label Oct 15, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

yum update without confirmation. (conan-io#3747)
* yum update without confirmation.

* sudo yum update without user's confirmation

* sudo yum update without user's confirmation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.