Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle old versions (<1.8) of SVN #3757

Merged
merged 3 commits into from Oct 19, 2018
Merged

Handle old versions (<1.8) of SVN #3757

merged 3 commits into from Oct 19, 2018

Conversation

@jgsogo
Copy link
Member

@jgsogo jgsogo commented Oct 16, 2018

Changelog: Fix: Use XML output to retrieve information from SVN command line if its client version is less than 1.8 (command --show-item is not available).

Changelog: Fix: SVN v1.7 does not have -r argument in svn status, so functionality SVN::is_pristine won't be available.

  • close #3737
  • No docs needed.

Here it is a PR to handle interface changes (detected up to now) between SVN 1.7.x and newer versions:

image

It should work for the use-cases reported up to now, but new issues will raise and we are not running CI tests with old SVN versions so we may break something in the future 馃槹

@jgsogo jgsogo added this to the 1.9 milestone Oct 16, 2018
@jgsogo jgsogo requested a review from lasote Oct 16, 2018
@ghost ghost assigned jgsogo Oct 16, 2018
@ghost ghost added the stage: review label Oct 16, 2018
@jgsogo jgsogo dismissed danimtb鈥檚 stale review Oct 16, 2018

Incoming changes related to svn1.7, I'll ping you when it is ready to review again.

@jgsogo jgsogo changed the title Use XML instead of --show-item if SVN version is less than 1.10 Handle old versions (<1.8) of SVN Oct 16, 2018
jgsogo added 2 commits Oct 16, 2018
* do not use --show-item for SVN under API change method

* handle relative-url for svn <= 1.7

* SVN::is_pristine always return False for old svns

* skip pristine tests for old svn
@jgsogo jgsogo requested a review from danimtb Oct 16, 2018
@danimtb
Copy link
Member

@danimtb danimtb commented Oct 18, 2018

Why not using XML for any SVN version to avoid having a double logic?

@jgsogo
Copy link
Member Author

@jgsogo jgsogo commented Oct 19, 2018

--show-item is the future, it is easier to parse because it returns just the output you requested... it is just an argument, but I have nothing more to support it.

@lasote lasote merged commit 12aed67 into conan-io:develop Oct 19, 2018
2 checks passed
@ghost ghost removed the stage: review label Oct 19, 2018
grisumbras pushed a commit to grisumbras/conan that referenced this issue Dec 27, 2018
* Use XML instead of --show-item if SVN version is less than 1.10

* Issue/svn1.7 (conan-io#4)

* do not use --show-item for SVN under API change method

* handle relative-url for svn <= 1.7

* SVN::is_pristine always return False for old svns

* skip pristine tests for old svn

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants