Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix link_flags management with MSBuild #3791

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
3 participants
@SSE4
Copy link
Contributor

commented Oct 18, 2018

closes #3790
closes #3105

Changelog: Fix: Fixed link_flags management in MSBuild build helper

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.
- fix link_flags management with MSBuild
Signed-off-by: SSE4 <tomskside@gmail.com>

@ghost ghost added the contributor pr label Oct 18, 2018

@SSE4 SSE4 changed the title - fix link_flags management with MSBuild Fix: fix link_flags management with MSBuild Oct 18, 2018

@lasote lasote self-requested a review Oct 20, 2018

@lasote lasote added this to the 1.9 milestone Oct 20, 2018

@jgsogo

jgsogo approved these changes Oct 24, 2018

Copy link
Member

left a comment

LGTM

@lasote lasote merged commit e133bb0 into conan-io:develop Oct 26, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the contributor pr label Oct 26, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

- fix link_flags management with MSBuild (conan-io#3791)
Signed-off-by: SSE4 <tomskside@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.