Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: call vcvars for clang-cl as well #3832

Merged
merged 1 commit into from Oct 26, 2018
Merged

Conversation

@SSE4
Copy link
Contributor

@SSE4 SSE4 commented Oct 23, 2018

follow up on #3803
clang-cl also requires vcvars to be set, otherwise CMake generation fails (it will fail to find rc.exe)

Changelog: Fix: vcvars is also called in the CMake() build helper when clang compiler is used, not only with Visual Studiocompiler.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.
Signed-off-by: SSE4 <tomskside@gmail.com>
@ghost ghost added the contributor pr label Oct 23, 2018
@SSE4 SSE4 changed the title - call vcvars for clang-cl as well Fix: call vcvars for clang-cl as well Oct 23, 2018
@lasote lasote added this to the 1.9 milestone Oct 26, 2018
@lasote lasote merged commit d048380 into conan-io:develop Oct 26, 2018
2 checks passed
@ghost ghost removed the contributor pr label Oct 26, 2018
grisumbras pushed a commit to grisumbras/conan that referenced this issue Dec 27, 2018
Signed-off-by: SSE4 <tomskside@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants