Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed builds dirty checks #3834

Merged
merged 1 commit into from Oct 26, 2018
Merged

Conversation

@memsharded
Copy link
Member

@memsharded memsharded commented Oct 23, 2018

Changelog: Fix: Implement dirty checks in the cache build folder, so failed builds are not packaged when there is a build_id() method.

  • Refer to the issue that supports this Pull Request.
    Fix #2879
@ghost ghost assigned memsharded Oct 23, 2018
@ghost ghost added the stage: review label Oct 23, 2018
@memsharded memsharded added this to the 1.9 milestone Oct 23, 2018
@memsharded memsharded assigned lasote and unassigned memsharded Oct 23, 2018
@memsharded memsharded requested a review from jgsogo Oct 23, 2018
jgsogo
jgsogo approved these changes Oct 24, 2018
@lasote lasote merged commit 42248cb into conan-io:develop Oct 26, 2018
2 checks passed
@ghost ghost removed the stage: review label Oct 26, 2018
@memsharded memsharded deleted the feature/failed_build_dirty branch Oct 26, 2018
grisumbras pushed a commit to grisumbras/conan that referenced this issue Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants